Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic support for convert data (array<object>) to xlsx, csv... #985

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

up9cloud
Copy link

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the dev branch and not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested with all Quasar themes
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on a Electron app
  • Any necessary documentation has been added or updated in the docs (for faster update click on "Suggest an edit on GitHub" at bottom of page) or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

#244

TODO

  1. basic convert data to xlsx's format
  2. basic download file testcase.
  3. add download button to dataTable
  4. solve other platforms download issue.

@nothingismagick
Copy link
Contributor

This should be closed because the justifying issue was also closed.

#244

@rstoenescu
Copy link
Member

This would be a good app extension. Should not be closed.

@nothingismagick
Copy link
Contributor

ok - maybe @hawkeye64 will be bored soon. :D

@nothingismagick
Copy link
Contributor

For inspiration: https://tableconvert.com/documentation.html

@edgar-koster
Copy link
Contributor

I was reading along for something else when I saw this. What is the idea here for I have a working situation to export a q-table to excel where there the dataset of the table is used in the export. The export file uses the same functions I use in my q-table file. Only thing, that is enhanced too. So if the table is to use a specific defined function to display data, export does too. If the qtable is to hide the column (my own show/hide) then the export too doesn't have it. Sorting is also the same. Header row is filtered in the excel. I use exceljs for it.

@rstoenescu
Copy link
Member

Hi,

Awesome work!

However, this would be great for an App Extension, but definitely not for Core... it imports external dependencies (xlsx), which is a 100% no-go for Core UI. Only xlsx is almost 500KB minified, not to mention it also imports other packages as well. If we merge this into Core, then the full version of shipped Quasar would jump in size to at least 5x times more.

In any case, please do not close the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants