Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 11ty’s Compatibility API #55

Merged
merged 4 commits into from
Sep 23, 2022
Merged

Use 11ty’s Compatibility API #55

merged 4 commits into from
Sep 23, 2022

Conversation

ovlb
Copy link
Contributor

@ovlb ovlb commented Sep 22, 2022

Replaces peerDependencies with 11ty’s internal compatibility API. This allows to install the package e.g. with 2.0.0@canary, which fails using peerDependencies, as npm’s dependency API does not consider the dependency as fulfilled.

See this issue for discussion and solution: 11ty/eleventy-dev-server#5

@ovlb ovlb marked this pull request as ready for review September 22, 2022 16:49
@ovlb ovlb changed the title Use 11ty’s Compatiblity API Use 11ty’s Compatibility API Sep 22, 2022
@nunof07
Copy link
Member

nunof07 commented Sep 22, 2022

Thanks @ovlb, makes sense!

Can you please address the lint issues?
You can ignore the console one...

@ovlb
Copy link
Contributor Author

ovlb commented Sep 22, 2022

@nunof07 Thanks. I’ve fixed the errors. I think I need to add the whole putout plugin to disable the console one. If you know of a way to only disable the remove-console rule, I’m happy to update this again.

🦉

@nunof07 nunof07 merged commit e6990e5 into quasibit:master Sep 23, 2022
@nunof07
Copy link
Member

nunof07 commented Sep 23, 2022

Thank you, @ovlb , very much appreciate it!

@github-actions
Copy link

🎉 This PR is included in version 2.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ovlb ovlb deleted the patch-1 branch September 23, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants