add AudioInfo.StreamDecorator feature #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a breaking change: OGG will no longer be wrapped in an InfiniteLoop by default. Use StreamDecorator=LoopOGG to get the old behavior. As for WAVs, it's now possible to disable the in-memory approach this library has (use NopDecorator). This can be handy for games with tons of WAVs (hundreds or thousands). It's still recommended to keep all SFX in-memory for smaller games and at least keep the most frequent sounds for large games. This new StreamDecorator feature will be essential to the upkoming custom audio loaders feature. It also makes it possible to use custom decorators like your own infinite loop implementation, etc.
quasilyte
force-pushed
the
quasilyte/stream_decorators
branch
from
3502dd8
to
2d2f089
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change: OGG will no longer be wrapped in an InfiniteLoop by default. Use StreamDecorator=LoopOGG to get the old behavior.
As for WAVs, it's now possible to disable the in-memory approach this library has (use NopDecorator).
This can be handy for games with tons of WAVs (hundreds or thousands). It's still recommended to keep all SFX in-memory for smaller games and at least keep the most frequent sounds for large games.
This new StreamDecorator feature will be essential to the upkoming custom audio loaders feature.
It also makes it possible to use custom decorators like your own infinite loop implementation, etc.