Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruleguard/quasigo: fix flaky NoAllocs test #196

Merged
merged 1 commit into from
Jan 31, 2021
Merged

Conversation

quasilyte
Copy link
Owner

When measuring Call() allocations, sometimes irrelevant
allocations happen in the process.

To avoid false positives, we do 5 attempts instead of 1.
If Call() does allocate, all 5 runs would show non-zero results.

Fixes #191

When measuring `Call()` allocations, sometimes irrelevant
allocations happen in the process.

To avoid false positives, we do 5 attempts instead of 1.
If `Call()` does allocate, all 5 runs would show non-zero results.

Fixes #191
@quasilyte quasilyte merged commit c7281c1 into master Jan 31, 2021
@quasilyte quasilyte deleted the quasilyte/fix/191 branch January 31, 2021 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NoAlloc tests seem to be flaky
1 participant