ruleguard: ignore match expr width limit for suggestions #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It does make sense to truncate output when printing the suggestions to the stdout. It's bad if we try to apply the truncated suggestions to a file though, it leads to a broken syntax with meta variables inserted instead of the actual replacements. 1. For the command-line output, increase the width limit to 60 (instead of 40). 2. When applying -fix suggestions, ignore the width limit. Fixes #57 Signed-off-by: Iskander Sharipov <quasilyte@gmail.com>
cristaloleg
approved these changes
Jul 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It does make sense to truncate output when printing the
suggestions to the stdout. It's bad if we try to apply
the truncated suggestions to a file though, it leads
to a broken syntax with meta variables inserted instead
of the actual replacements.
Fixes #57
Signed-off-by: Iskander Sharipov quasilyte@gmail.com