add a noAction() method to Object and FileWriter to return the noaction flag value #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion flag value. Update Process to use this new method.
|
Looks good! |
jrha
added a commit
that referenced
this pull request
Jul 22, 2014
add a noAction() method to Object and FileWriter to return the noaction flag value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also update Process to use this new method.
The rationale of this pull request is to provide a uniform way of retrieving the noaction flag value, whether the object is based on CAF::Object or CAF::FileWriter (which is not a CAF::Object).
A typical use case is demonstrated in
ncm-named(quattor/configuration-modules-core#243) to avoid printing an error message in unit tests when a file was not updated because of the noaction flag defined in the tests..