provide an interface to access generated output more as a stream #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
to be used in replacement of code in quattor/ncm-cdispd#9 to handle |
| # not called with empty remainder | ||
| if ($remainder) { | ||
| $process->(@process_args, $remainder); | ||
| $total_out .= $remainder; |
There was a problem hiding this comment.
It's faster to make @total_out, a list, and then push to it and return its join(''.
|
Minor nitpicking, but it's indeed an useful addition. |
|
The code is fine. We just need to improve the documentation. |
|
As discussed at the standup, sort out the conflicts and this can be merged |
|
Wasn't difficult, so I did it myself 👸 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.