Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: module for new CCM CLI (and ccm script) (Preview) #65

Merged
merged 12 commits into from Aug 20, 2015

Conversation

stdweird
Copy link
Member

@stdweird stdweird commented Aug 9, 2015

A new module for extensible and unittested commandline interface, incl ccm script that uses it and similar extensible and unittested tabcompletion.
Based on #62 and #64

@stdweird stdweird added this to the 15.8 milestone Aug 9, 2015
@hpcugentbot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/CCM-pr-builder/150/
Test PASSed (test).


=head1 OPTIONS

For the list op options, check the C<EDG::WP4::CCM::CLI> and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant "op" before options? Also CEDG::WP4::CCM::CLI should be LEDG::WP4::CCM::CLI to ensure things like correctly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah - I guess you mean of not op?

@stdweird
Copy link
Member Author

retest this please

@hpcugentbot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/CCM-pr-builder/156/
Test PASSed (test).

@hpcugentbot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/CCM-pr-builder/159/
Test PASSed (test).

@hpcugentbot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/CCM-pr-builder/160/
Test PASSed (test).

@stdweird
Copy link
Member Author

@ned21 wrt the bash buitins, i'm quite sure previous EL5 releases shipped bash that didn't have such support. i just checked on a 5.11 box, it does have it, but TUV could have backported this. the code you commented on is only run once during the souce-ing of the tabcompletion script, so it's not slowing the actual tabcompletion.

@ned21
Copy link
Contributor

ned21 commented Aug 16, 2015

OK, makes sense - I make no claims to be competent at bash-ing :-) Any chance of a fix to the docs - there's a typo when you said op instead of of and the C<..> should be replaced by L<...> to link man pages together. Otherwise I think this is good to go.

@hpcugentbot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/CCM-pr-builder/161/
Test PASSed (test).

@stdweird
Copy link
Member Author

@ned21 remarks fixed. could you also make a comment in #64 to indicate that that one is also fine (as this PR is based on that one).

@ned21
Copy link
Contributor

ned21 commented Aug 17, 2015

I merged #64. Does anyone want to try out this new CLI before we merge it?

@stdweird
Copy link
Member Author

@ned21 as long as quattor/CAF#98 is not resolved in some way, the output will be mixed with other output.

[root@host ~]# source /etc/bash_completion.d/quattor-ccm 
[root@host ~]# ccm --
--base_url          --cfgfile           --debug             --keep_old          --preprocessor      --retrieve_retries  --trust
--cache_root        --cid               --force             --key_file          --profile           --retrieve_wait     --world_readable
--ca_dir            --component         --format            --lock_retries      --profile_failover  --show              
--ca_file           --context           --get_timeout       --lock_wait         --profpath          --showcids          
--cert_file         --dbformat          --json_typed        --metaconfig        --purge_time        --tabcompletion     
[root@host ~]# ccm --for
--force   --format  
[root@host ~]# ccm --for
--force   --format  
[root@host ~]# ccm --format 
json           pan            pancxml        tabcompletion  yaml           
[root@host ~]# ccm --format json --profpath /system/
/system/aii/           /system/cluster/       /system/kernel/        /system/network/       /system/rootmail       /system/state
/system/blockdevices/  /system/filesystems/   /system/monitoring/    /system/quattorid      /system/siterelease    
[root@host ~]# ccm --format json --profpath /system/network/ --show
updated /var/lib/ccm/profile.9/ccm-active-profile.9-6562.writetest
updated /var/lib/ccm/profile.9/ccm-active-profile.9-6562
{"default_gateway":"1.2.3.4","domainname":"ugent.be","hostname":"host","interfaces":{"eth0":{"broadcast":"1.2.3.255","driver":"e1000","ip":"1.2.3.10","netmask":"255.255.255.0"}},"nameserver":["1.2.3.243"],"nozeroconf":true,"set_hwaddr":true}

@stdweird stdweird changed the title CLI: module for new CCM CLI (and ccm script) CLI: module for new CCM CLI (and ccm script) (Preview) Aug 20, 2015
ned21 added a commit that referenced this pull request Aug 20, 2015
CLI: module for new CCM CLI (and ccm script)
@ned21 ned21 merged commit 8ab93be into quattor:master Aug 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants