Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aii-web: FIX errors and add JSON profiles suport #108

Merged
merged 2 commits into from Mar 24, 2015
Merged

aii-web: FIX errors and add JSON profiles suport #108

merged 2 commits into from Mar 24, 2015

Conversation

samary
Copy link

@samary samary commented Mar 8, 2015

  • Some variables were not initialized
  • add support for JSON profiles via GET variable

FIX errors and add JSON profiles suport
db7b0a8 
* Some variables were not initialized
* add support for JSON profiles via GET variable
@hpcugentbot
Copy link

Automatic reply from Jenkins: Can I test this?

stdweird
stdweird reviewed Mar 9, 2015
View reviewed changes
aii-core/src/main/perl/aii-web.cgi
@@ -9,11 +9,14 @@
# is missing the node will boot from the hard disk
my $boothd = "default";

# Quattor XML profiles
# Quattor profiles
my $web_root = "/var/www/html";
my $profiles_path="profiles";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spaces around =

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, was not part of my diff.

@stdweird
Copy link
Member

stdweird commented Mar 9, 2015

test this please

@hpcugentbot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/AII-pr-builder/214/
Test PASSed.

Update
fd3ba38 
- use profile_prefix variable (should be read from config file) to avoid hardcoded one
- define extension by GET variable
@jrha jrha added this to the 15.4 milestone Mar 10, 2015
@jrha jrha changed the title FIX errors and add JSON profiles suport aii-web: FIX errors and add JSON profiles suport Mar 24, 2015
@jrha
Copy link
Member

jrha commented Mar 24, 2015

LGTM

jrha added a commit that referenced this pull request Mar 24, 2015
@jrha
Merge pull request #108 from samary/patch-1
1ce3ee4 
aii-web: FIX errors and add JSON profiles suport
@jrha jrha merged commit 1ce3ee4 into quattor:master Mar 24, 2015
@samary samary deleted the patch-1 branch March 29, 2015 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
15.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@samary @hpcugentbot @stdweird @jrha