Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine regex to identify PXE entries in available boot entries #339

Closed
wants to merge 1 commit into from
Closed

Refine regex to identify PXE entries in available boot entries #339

wants to merge 1 commit into from

Conversation

jouvin
Copy link
Contributor

@jouvin jouvin commented Jul 13, 2023

Fixes #338

@jouvin
Refine regex to identify PXE entries in available boot entries
bc311b1 
- Exclude 'Network Boot' entries available on HPE machines like Apollo 4200
- Exclude HTTP entries available on some machines

Fixes quattor#338
@jouvin jouvin requested review from jrha and stdweird July 13, 2023 15:08
@jouvin
Copy link
Contributor Author

jouvin commented Jul 13, 2023

May be good to add a few tests for the improved regex but I had no time to do it yet...

@jouvin
Copy link
Contributor Author

jouvin commented Jul 18, 2023 •
edited

Abandoned after @wpoely86 's suggestion in #338 to just set BootCurrent as the first entry.

@jouvin jouvin closed this Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrha jrha Awaiting requested review from jrha

@stdweird stdweird Awaiting requested review from stdweird

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aii-ks 21.12: regex for identifying PXE boot entries not strict enough
1 participant
@jouvin