-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fixes issue: 343] Adding capability to set bootloader filename #344
base: master
Are you sure you want to change the base?
[Fixes issue: 343] Adding capability to set bootloader filename #344
Conversation
I don't think you need AII to configure anything in DHCP. It is currently support by AII to boot in rescue mode (can in fact be anything you have configured) by executing "aii-shellfe --rescue node.name". To work, you need to write a Grub2 config file rescue.cfg file similar to localboot.cfg that will be used by the node when booting. rescue.cfg can be something like (not sure it is a working configuration): set default=0
|
We specifically need to use a different bootloader when using rescue mode. This is an edge case ESXi hypervisors' UEFI booting:
|
if ($opts->(filename)) { | ||
$filename = $opts->(filename); | ||
} | ||
if ($rescue eq 'rescue' && $opts->(rescue)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why it is not an elsif
? It makes no point to set the filename to $opts->(filename)
in rescue mode or did I miss something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There might be a case when there's 'filename' set, and 'rescue' not, also if both 'filename' and 'rescue' are set.
I wanted to make sure if there's a 'filename' set, get it anyway, and if there's 'rescue' there as well, overwrite it.
0a507ed
to
0459d0d
Compare
…ofile This commit adds the feature to aii-dhcp plugin to fetch bootloader filename for DHCP config to be included. Also handles situation if default bootloader may differ from the one would be used in case of rescue mode.
0459d0d
to
2c33e2b
Compare
Adding capability to set bootloader filename
This commit adds the feature to aii-dhcp plugin to fetch bootloader filename for DHCP config to be included. Also handles situation if default bootloader may differ from the one would be used in case of rescue mode.