Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aq show network: misaligned columns #59

Closed
jouvin opened this issue Mar 24, 2017 · 5 comments
Closed

aq show network: misaligned columns #59

jouvin opened this issue Mar 24, 2017 · 5 comments
Assignees

Comments

@jouvin
Copy link
Contributor

jouvin commented Mar 24, 2017

In aq show network date lines have columns misaligned with the header line, if the network name is longer than Network.

@jrha
Copy link
Member

jrha commented Mar 27, 2017

It would be good to use a tabulation library to render the output, I believe @msmark also demonstrated a wrapper (https://github.com/quattor/aquilon-tools/blob/master/src/bin/aqnet ?) at the Autumn workshop.

@jrha
Copy link
Member

jrha commented Mar 27, 2017

Also column -t does a good job (apart from the comments column).

aq show_network --all | column -t

@urbonegi
Copy link

urbonegi commented Oct 26, 2017

So the raw formater output does misalign the Network output intentionally (Network name has 0 indentation, then its details have 2 spaces indentation, building details are indented by 4 spaces, then if there would be any static routes, their personality details would be indented by 6 spaces):

Network: very-long-network-name-which-is-ok-cause-it-can-use-all-the-screen-width
  Network Environment: internal
  IP: 127.0.0.1
  Netmask: 255.255.224.0
  Sysloc: xx.xx.xy
  Building: xx
    Fullname: XX
    Address: Planet Earth
    Location Parents: [Organization quattor, Hub xx, Continent xx, Country xx, Campus xx, City xx]
  Side: a
  Network Type: unknown

Could you should an example of wrong alignment, cause I do not see what is wrong here. If you are trying to script around Aquilon broker, you should either use protobuf or csv output format, not raw output.

@jrha
Copy link
Member

jrha commented Oct 26, 2017

@urbonegi This looks like the details for a single network, the problem was when printing all networks.

@jrha
Copy link
Member

jrha commented Oct 26, 2017

Aha! @gombasg removed the tabular network list functionality in fd08fd7 as part of the IPv6 support.

@jrha jrha closed this as completed Oct 26, 2017
ned21 pushed a commit to ned21/aquilon that referenced this issue Mar 4, 2020
…merge/master/by_topic/new_hosts_should_not_use_wrong_building_fqdns_unless_forced to master

* commit '5c0ee8410c70810e9271e3b939358aae16749ff0':
  Prevent use of wrong DNS domains for buildings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants