aq pxeswitch: allow to configure aii-installfe cdburl #114
Conversation
etc/aqd.conf.defaults
Outdated
| @@ -155,6 +155,8 @@ plenarydir = %(cfgdir)s/plenary | |||
| service = %(user)s | |||
| keytab = /var/spool/keytabs/%(service)s | |||
| installfe_user = %(user)s | |||
| # Uncomment and define installfe_cdburl if you want Aquilon to manage cdburl | |||
| #installfe_cdburl = Aquilon profiles URL | |||
There was a problem hiding this comment.
The point of has value is that it allows to keep the empty variable namespace without a need to comment it out. Suggest to do this like it:
# Define installfe_cdburl if you want Aquilon to manage cdburl
installfe_cdburl =
There was a problem hiding this comment.
It was what I did initially but I got an error with an empty value... I should probably retest it but as I'm leaving tomorrow evening for one month, I am not sure I'll be able to do it before... Will do my best!
There was a problem hiding this comment.
Please share the error, but i tested the has_value plenty of times.. weird...
|
I confirm that having an empty value works like a charm! Not sure what I made wrong in my initial tests... |
|
Hang on, this assumes you only have one cdburl across your entire plant. In case it isn't obvious why this might be useful, consider very restricted environments such as clusters inside a private network which may use reverse proxies to provide monitored access to external resources. OTOH it should only affect shared AII servers and not using currently does the right thing, so it may not matter. |
|
@jrha I don't understand your point. It assumes only that you have one cdburl per broker. You can set the cdburl differently on each broker. |
|
You may have one broker, but multiple URLs that serve profiles from it: mirrors, reverse proxies etc. As I said, I don't think it matters that much, you can configure the AII server however you want unless you use the override for a shared server. |
|
I understand, I didn't have this configuration in mind... But as you say, if you are using the configuration you mention, probably the price to pay is that sharing the AII server with SCDB is more complicated... A service instance based approach may bring a more general solution but looks to me as much more complex as there is no way AFAIK to define data to be passed to the service by the broker (not in a template), as in this particular case it is the broker which is building the If it is acceptable for you, I'd appreciate to see this PR merged to make SCDB transition easier. |
|
Sure, I don't really have a problem with this PR, just wanted to flag it! |
|
Can this be rebased on the current master please? |
|
Done |
|
@jouvin so actually, it was not working but because of a change in the version of the panc compiler (an error message that changed). With the new master it should work. Could you please rebase ? I will post that same message in other pull requests sharing the same issue. Sorry for asking the rebase a second time. Looking at the rest of the tests, this should be fine this time, and I'll try to merge it asap :) |
jouvin
force-pushed
the
pxeswitch_cdburl
branch
from
500ec22
to
200f6c1
Compare
- This helps with sharing an AII server between several sources, in particular between SCDB and Aquilon - Option installfe_cdburl is undefined by default (cdburl not managed by Aquilon) Fixes quattor#113 (quattor#113) Change-Id: I80e8711f267863c44ecd5e6b8661ee926aab7628
|
@XaF No problem, done! |
|
Merged in 235644e |
This helps with sharing an AII server between several sources, in particular between SCDB and Aquilon.
Fixes #113 (#113)
Requires quattor/aii#291 (
aii-installfecounterpart) to be useful.