Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Aquilon README #36

Merged
merged 12 commits into from
Mar 23, 2017
Merged

Fix Aquilon README #36

merged 12 commits into from
Mar 23, 2017

Conversation

guillaume-philippon
Copy link
Contributor

Hi,

This PR is to fix documentation of Aquilon installation.

@ned21
Copy link
Contributor

ned21 commented Oct 6, 2016

Notifying @ajf8 @gombasg

@gombasg
Copy link
Contributor

gombasg commented Mar 21, 2017

The ms.version.addpkg() parameters should not be changed - that would break our setup.

@guillaume-philippon
Copy link
Contributor Author

I remove all non-documentation modification

@jrha
Copy link
Member

jrha commented Mar 21, 2017

LGTM

@guillaume-philippon
Copy link
Contributor Author

Not sure it s enough to build a working aquilon server. Perhaps, The PR must be a base for installation hand-on and fixe what still miss

@jouvin
Copy link
Contributor

jouvin commented Mar 22, 2017

March 17 workshop: complete and merge after the hands on session at the workshop

README: additional cleanups after the workshop hands-on
@jrha
Copy link
Member

jrha commented Mar 23, 2017

Ideally this should be pulled in to a MS branch for internal review and pushed back to Github from there.

README.md Outdated

Run as root to install to a system directory, or run as a normal user
to install into a user-writable location.
If the installation is done as root and all the dependencies (liste in `/opt/aquilon/setup.py` have been installed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

listed

README.md Outdated
Run as root to install to a system directory, or run as a normal user
to install into a user-writable location.
If the installation is done as root and all the dependencies (liste in `/opt/aquilon/setup.py` have been installed
as RPM or using the `pip` command, there is no more installation steps to do and you should be able to run the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are no more

README.md Outdated

An environment has now been setup appropriate for running commands and development.
* The `cx_Oracle` install will fail if there is no local Oracle client installed - that's fine.
* `cdb` package installed as a RPM will be reported as missing but it should not prevent the installation to work
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

installation from working

README.md Outdated

(ignore warning on administration not setup)
Be sure to definie properly the domain associated with your realm: it must match your actual
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

properly definie

README.md Outdated

and
It is recommended not to run the broker as root. This is causing quite a number of problem with
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is causes

@jouvin
Copy link
Contributor

jouvin commented Mar 23, 2017

@guillaume-philippon I let you fix the typos, it would be easier.

@guillaume-philippon
Copy link
Contributor Author

I m waiting the feedback of @samary and @rhumroux before pushing the typo fix

@jouvin
Copy link
Contributor

jouvin commented Mar 23, 2017

@guillaume-philippon you forgot to merge my PR to your branch with the cleanup I did yesterday evening... I guess I need to rebase it... I'm checking right now.

- PyCharm and Eclipse project information excluded
README.md Outdated
domain.

If you don't run as `root`, be sure to create a keytab for the current user.

### Create a User to Run the Broker

It is recommended not to run the broker as root. This is causing quite a number of problem with
It is recommended not to run the broker as root. This cause quite a number of problem with
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

causeS

@jouvin
Copy link
Contributor

jouvin commented Mar 23, 2017

PR on your source branch has been rebased on this PR and can be merged.

Git repository initialization clarifications
@jouvin
Copy link
Contributor

jouvin commented Mar 23, 2017

It seems you need to rebase the PR on the last version of master as there is a conflict with .gitignore.

@jouvin
Copy link
Contributor

jouvin commented Mar 23, 2017

We still need to fix the Git initialization when you are back and after testing it again. I merge this PR as it is already a good start and we'll fix the last point in a future PR.

@jouvin jouvin merged commit 141c501 into quattor:upstream Mar 23, 2017
@ned21
Copy link
Contributor

ned21 commented Mar 23, 2017

@jouvin I don't think you can just merge things onto this branch. These commits will get lost the next time there's a push from our internal repo. We need Gabor and Dave to determine the correct way for us to accept these patches.

@ned21 ned21 mentioned this pull request Mar 23, 2017
@jouvin
Copy link
Contributor

jouvin commented Mar 23, 2017

@ned21 sorry, I forgot this detail... I really apologize for that. At the same time, we need to expose a better installation documentation so I'd suggest to keep it merged and saved somewhere else (I have it in my fork and clone anyway). These changes should not conflict with MS development as I think the README file has been maintained mainly by us in fact...).

@ned21
Copy link
Contributor

ned21 commented Mar 23, 2017

@jouvin Definitely! Dave is out tomorrow but I'll sync up with him next week and we'll start meeting more regularly on the stand up.

jouvin added a commit to jouvin/quattor.github.com that referenced this pull request Mar 28, 2017
- Installation guide updated with aquilon repo README.md
  from quattor/aquilon#36
jouvin added a commit to jouvin/aquilon that referenced this pull request Mar 28, 2017
- README contents from quattor#36 moved to Quattor web site
jouvin added a commit to jouvin/aquilon that referenced this pull request Mar 28, 2017
- README contents from quattor#36 moved to Quattor web site

Fixes quattor#57.
jouvin added a commit to jouvin/aquilon that referenced this pull request Mar 28, 2017
- README contents from quattor#36 moved to Quattor web site

Fixes quattor#57.
jouvin added a commit to jouvin/quattor.github.com that referenced this pull request Mar 28, 2017
- Installation guide updated with aquilon repo README.md
  from quattor/aquilon#36
jouvin added a commit to jouvin/quattor.github.com that referenced this pull request Mar 30, 2017
- Installation guide updated with aquilon repo README.md
  from quattor/aquilon#36
jrha pushed a commit to jrha/quattor.github.com that referenced this pull request Apr 12, 2017
- Installation guide updated with aquilon repo README.md
  from quattor/aquilon#36
jouvin added a commit to jouvin/aquilon that referenced this pull request Apr 27, 2017
- README contents from quattor#36 moved to Quattor web site

Fixes quattor#57.

Change-Id: I0a1a67758c478471f0ca4c81b695ea8c489d0cf1
urbonegi pushed a commit that referenced this pull request May 24, 2017
- README contents from #36 moved to Quattor web site

Fixes #57.

Change-Id: I0a1a67758c478471f0ca4c81b695ea8c489d0cf1
Reviewed-By: Fred Barnes <Fred.Barnes@morganstanley.com>
XaF pushed a commit that referenced this pull request Nov 28, 2018
…aster/by_topic/hlmpp to master

* commit '4907f58394411c1865f59e9a87c43745f4b5705c':
  refresh_user: use a source script instead of a source list
  Add user type database table and related commands
  tests/broker/orderedsuite: cleanup import order
  doc: cat.xml: cleanup and make the doc accurate
  optparser: improve requirements and conflicts handling
  dbwrappers: location: add an extended get_locations function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants