ncm-directoryservices ncm-fmonagent ncm-mcx: Deprecate with warnings #1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdweird
reviewed
Feb 27, 2017
| @@ -24,5 +24,7 @@ type component_directoryservices = { | |||
| "ldapv3" ? directoryservices_ldap_entry{} | |||
| }; | |||
|
|
|||
| bind "/software/components/directoryservices" = component_directoryservices; | |||
|
|
|||
| bind "/software/components/directoryservices" = component_directoryservices with { | |||
There was a problem hiding this comment.
any reason why this is done at the bind, not at the type itself? (not that i care 😄 )
There was a problem hiding this comment.
It just feels more appropriate at the point it is actually used.
stdweird
approved these changes
Feb 27, 2017
|
Is Jenkins okay? It seems like it's taking forever to build PRs at the moment. |
|
ran out of inodes, we're cleaning up atm |
|
retest this please |
|
🥗 ! |
|
@stdweird I'll let you merge this if you want to do the deprecation in this release cycle. |
|
Ok. |
jrha
force-pushed
the
archive-components
branch
from
c5db4d2
to
7f85a88
Compare
|
Discussed at March 2017 workshop... no longer deprecates syslogng as it is expected to live on for some time at RAL and MS. |
jrha
changed the title
|
@stdweird this should be good to merge now |
This was referenced Sep 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throw deprecation if the following components are initialised:
This is the first step towards #1027.