Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ncm-nfs: mount type for cephfs is ceph #1194

Merged
merged 3 commits into from Dec 19, 2017
Merged

ncm-nfs: mount type for cephfs is ceph #1194

merged 3 commits into from Dec 19, 2017

Conversation

kwaegema
Copy link
Member

stdweird
stdweird previously approved these changes Nov 24, 2017
@stdweird stdweird added this to the 17.12 milestone Nov 24, 2017
@jrha
Copy link
Member

jrha commented Nov 24, 2017

Has this always been wrong or did it change in a ceph release?

Also please develop in a fork of this repository rather than branches inside it.

@jrha
Copy link
Member

jrha commented Nov 24, 2017

Answered my own question: it's been ceph since the days of dumpling http://docs.ceph.com/docs/dumpling/cephfs/fstab/, whoops.

@jrha
Copy link
Member

jrha commented Nov 29, 2017

@kwaegema there are still references to cephfs in the unit tests, could you update them?

@jrha
Copy link
Member

jrha commented Dec 8, 2017

@kwaegema I updated this for you, will squash the commits when merging.

@jrha jrha merged commit 4690322 into master Dec 19, 2017
@jrha jrha deleted the kwaegema-patch-2 branch December 19, 2017 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants