Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ncm-sudo: spring cleanup #1247

Merged
merged 2 commits into from Apr 3, 2018
Merged

ncm-sudo: spring cleanup #1247

merged 2 commits into from Apr 3, 2018

Conversation

stdweird
Copy link
Member

@stdweird stdweird commented Mar 9, 2018

Backwards incompatible due to

  • renamed schema related functions, types and templates
  • both spma and accounts are now predependencies

@stdweird stdweird added this to the 18.3 milestone Mar 9, 2018
@stdweird
Copy link
Member Author

stdweird commented Mar 9, 2018

@ned21 is the accounts predependency an issue for MS?
you can easily override it with site templates, once quattor/maven-tools#170 is released and the new release makes use of it

@stdweird
Copy link
Member Author

stdweird commented Mar 9, 2018

also, we need the accounts and spma dependency for spmalight

@ned21
Copy link
Contributor

ned21 commented Mar 9, 2018

Yes the dependency on accounts is a problem for us (and anyone else not using something other than ncm-accounts). I don't think renaming schema functions or types is particularly backwards incompatible (unless you are reusing them outside the component). Changing the schema itself would be a real problem for us because the number of Quattor versions we have in use is high, and in order to keep up with the code versions we are no longer version locking the component rpms in templates. So we have one set of templates and then control the rpm versions installed by repointing the yum repos on the host.

I haven't read the second commit in detail yet.

@stdweird
Copy link
Member Author

@ned21 wet dependencies on spma and accounts, is the current code with possibility of site-config ok? (once the fixes are released)

@ned21
Copy link
Contributor

ned21 commented Mar 11, 2018

The second code looks fine. I think being able to remove the account dependency via site-defaults will be fine since we already remove spma that way.

Copy link
Member

@jrha jrha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm going diff-blind

@jrha jrha merged commit 710accb into quattor:master Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants