New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ncm-sudo: spring cleanup #1247
ncm-sudo: spring cleanup #1247
Conversation
@ned21 is the accounts predependency an issue for MS? |
also, we need the accounts and spma dependency for spmalight |
Yes the dependency on accounts is a problem for us (and anyone else not using something other than ncm-accounts). I don't think renaming schema functions or types is particularly backwards incompatible (unless you are reusing them outside the component). Changing the schema itself would be a real problem for us because the number of Quattor versions we have in use is high, and in order to keep up with the code versions we are no longer version locking the component rpms in templates. So we have one set of templates and then control the rpm versions installed by repointing the yum repos on the host. I haven't read the second commit in detail yet. |
@ned21 wet dependencies on spma and accounts, is the current code with possibility of site-config ok? (once the fixes are released) |
The second code looks fine. I think being able to remove the account dependency via site-defaults will be fine since we already remove spma that way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'm going diff-blind
Backwards incompatible due to