Add 'log' to the permissible targets of the nat table #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that have log as a target will result in a broken iptables configuration.
|
Automatic reply from Jenkins: Can I test this? |
|
test this please |
|
Merging in. Thanks for the contribution. |
piojo-zz
pushed a commit
that referenced
this pull request
Jan 22, 2014
Add 'log' to the permissible targets of the nat table
aka7
pushed a commit
to aka7/configuration-modules-core
that referenced
this pull request
Oct 14, 2022
Add support for vxfs and zfs filesystem types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
otherwise rules that have log as a target will result in a broken iptables configuration.
In particular, instead of the rules appearing in /etc/sysconfig/iptables under
we get
which is not correct, and iptables-restore complains that a chain must not have the same name as a target.
The fix is really simple, and runs in production at our site. So please apply this!