Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ncm-metaconfig: add lvm_conf config support #1573

Merged
merged 1 commit into from Jul 27, 2023
Merged

Conversation

aka7
Copy link
Contributor

@aka7 aka7 commented Jan 4, 2023

ability to set lvm configuration. Using lvmlocal.conf.

All default options supported taken from output lvmconfig --typeconfig default on rhel7 and 8.

Fixes #1566

@aka7
Copy link
Contributor Author

aka7 commented Jan 4, 2023

I can't seem to get the tests to pass, if someone can help me with this I would appreciate it. @jrha

@aka7 aka7 requested a review from jrha January 4, 2023 12:32
@jrha jrha added this to the 23.next milestone Jul 24, 2023
@jrha jrha force-pushed the lvm_conf branch 7 times, most recently from b95602f to 1c7d6de Compare July 24, 2023 15:16
ability to set lvm configuration. Using lvmlocal.conf.

All default options supported taken from output lvmconfig --typeconfig default on rhel7 and 8.

Fixes quattor#1566
Copy link
Member

@jrha jrha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I'm now happy with this.
@aka7 can you check that the changes I've made make sense to you.

@jrha jrha modified the milestones: 23.next, 23.6 Jul 24, 2023
@jrha jrha merged commit 8bc14a6 into quattor:master Jul 27, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

ncm-metaconfig: add support to manage lvm.conf
2 participants