Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ncm-authconfig: sssd: Schema improvements #1622

Merged
merged 1 commit into from Oct 19, 2023
Merged

ncm-authconfig: sssd: Schema improvements #1622

merged 1 commit into from Oct 19, 2023
+94 −79

Conversation

jrha
Copy link
Member

@jrha jrha commented Aug 18, 2023

  • Use choice() where possible.
  • Use more specific types than just plain long and string.

Resolves #1471.

@jrha
ncm-authconfig: sssd: Schema improvements
a508c7f 
- Use `choice()` where possible.
- Use more specific types than just plain `long` and `string`.
@jrha jrha added this to the 23.9 milestone Aug 18, 2023
@jrha
Copy link
Member Author

jrha commented Aug 18, 2023

I've not tested this with any real config, so it would benefit from someone more familiar with sssd reviewing it carefully.

@jrha jrha modified the milestones: 23.9, 23.next Sep 28, 2023
@wpoely86
Copy link
Member

Tested with our tree. No issues whatsever.

@wpoely86 wpoely86 merged commit d6d1347 into quattor:master Oct 19, 2023
2 checks passed
@jrha jrha modified the milestones: 23.next, 23.9 Oct 31, 2023
@jrha jrha deleted the sssd_types branch October 31, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpoely86 wpoely86 wpoely86 approved these changes

Assignees
No one assigned
Labels
enhancement
Milestone
24.3
Development

Successfully merging this pull request may close these issues.

ncm-authconfig: sssd: tighten types
2 participants
@jrha @wpoely86