Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: update dockerfile to rockylinux:8 #1625

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

wpoely86
Copy link
Member

@wpoely86 wpoely86 commented Aug 24, 2023

This updates the dockerfile to be on sync with what we do in the github actions.

@aka7 build this with podman:

podman build -t quattor_test .

And then use it like:

podman run --user=$(id -ur):$(id -gr)  -it --userns=keep-id -v /path/to/configuration-modules-core:/quattor_test:z -e MVN_ARGS="-pl ncm-network" localhost/quattor_test

This runs the tests on your checkout.

@jrha
Copy link
Member

jrha commented Aug 24, 2023

Could we publish the container this builds and then use it as the base for all of our GitHub actions? It would speed things up.

Dockerfile Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
@wpoely86
Copy link
Member Author

Could we publish the container this builds and then use it as the base for all of our GitHub actions? It would speed things up.

I believe so. There is ghcr.io. We already use it for other containers and let it (cron wise) weekly rebuild with github actions.

Do you want to keep it in this repo?

@jrha
Copy link
Member

jrha commented Aug 25, 2023

Maybe it'd be better off replacing the Dockerfile in the release repo?

@wpoely86
Copy link
Member Author

Maybe it'd be better off replacing the Dockerfile in the release repo?

Yes, let me put it there and remove it here.

@jrha
Copy link
Member

jrha commented Aug 25, 2023

Cool, thanks! 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants