Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ncm-network: Throw error if commands used with nmstate #1631

Merged
merged 1 commit into from Sep 15, 2023
Merged

ncm-network: Throw error if commands used with nmstate #1631

merged 1 commit into from Sep 15, 2023
+6 −4

Conversation

jrha
Copy link
Member

@jrha jrha commented Sep 13, 2023

This is the schema part of the fix for #1627.

@jrha jrha added this to the 23.9 milestone Sep 13, 2023
@jrha jrha requested a review from aka7 September 13, 2023 10:02
@jrha jrha mentioned this pull request Sep 13, 2023
Merged
aka7
aka7 approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@aka7 aka7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
great team work :) Thank you James.

@jrha jrha merged commit d6ece90 into quattor:master Sep 15, 2023
2 checks passed
@jrha jrha deleted the nmstate_schema branch September 15, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aka7 aka7 aka7 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
24.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jrha @aka7