ncm-network: set profile-name and set dhcp to disable for static config #1637
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add profile name to make sure nmstateclt apply picks the right profile. - explicitly set dhcp to false when setting static address. if there is an existing connection for same device with dhcp enabled nmstate wll not apply the change unless dhcp is explicitly is set to false. closes quattor#1636
aka7
force-pushed
the
ncm_network_dhcp_false
branch
from
67aa014
to
ebce675
Compare
jrha
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1636
To make sure right profile config is used by NM when nmstate applies the config.
None.