ncm-network: nmstate - add additional route rule parameters #1659
Conversation
|
@jrha created this for discussion on if there will a way to create sperate schemas for nmstate only options. something to think about. as discussed before. this isnt urgent but at some point we may need to create unreachable routes and only way to do this with nmstate is through route-rules. |
- provide additional route rule parameters for nmstate config as defined in https://nmstate.io/devel/yaml_api.html#routes
aka7
force-pushed
the
ncm_network_nmstate_rule_param
branch
from
f47225c
to
1450ec3
Compare
|
I'll try and do some testing to establish a way of making the schema modular, but otherwise having these options as a separate |
| @@ -77,6 +77,16 @@ type structure_rule = { | |||
| "table" ? network_valid_routing_table | |||
| @{priority, The priority of the rule over the others. Required by Network Manager when setting routing rules.} | |||
| "priority" ? long(0..0xffffffff) | |||
| @{nmstate-action used by nmstate module} | |||
There was a problem hiding this comment.
i am not in favour of the naming.
at least make a structure_rule_nmstate and move them there.
are these simply ignored by the old network.pm code? if so, i see not much harm.
wrt separate scheam's i can make a PR. i need to work in the core schema anyway to add the IB support.
There was a problem hiding this comment.
@stdweird I may need some help/guide from you to move this into the new structure you created, please.
provide additional route rule parameters for nmstate config as defined in https://nmstate.io/devel/yaml_api.html#routes
allow creation of route rules with all options.
none.