New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ncm-network: fix documentation bonding example #416
Conversation
Refer to this link for build results (access rights to CI server needed): |
"/software/components/modprobe/modules" = | ||
push(nlist("name","bonding","options","mode=6 miimon=100")); | ||
include 'components/modprobe/config'; | ||
"/software/components/modprobe/modules" = push(nlist("name","bonding","alias","bond0")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
push() is deprecated in favour of append()
fixed remarks from @ned21 . |
Refer to this link for build results (access rights to CI server needed): |
"/system/network/interfaces/eth0/master"="bond0"; | ||
include 'components/network/config'; | ||
|
||
"/system/network/interfaces/eth0/bootproto" = "none"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use prefix instead copying /system/network/interfaces
over and over?
@stdweird fixed remarks |
Refer to this link for build results (access rights to CI server needed): |
ncm-network: fix documentation bonding example
The last commit is most relevant, this fixes the example to use
bonding_opts
instead of modules which does not work anymore.The rest is a cleanup of this pod: