ncm-systemd: initial support for systemd unit control #424

stdweird · 2015-02-25T16:23:19Z

Provide inital framework to handle systemd units.

stdweird · 2015-02-25T16:25:28Z

It's a lot of code, and it can't do much yet (but it's not so trivial as chkconfig 😄 )

Known issues

no target handling
too much verbose logging
not used to run anything 😄
no ncm-chkconfig drop in code

Feedback is welcome, no need to review the cmddata modules 😄

stdweird · 2015-02-25T16:26:56Z

@ned21 don't review per commit. There is some major rework done at the end, i'm open to suggestion how to rewrite the git history.

hpcugentbot · 2015-02-25T17:22:04Z

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/NCM_Components-pull_requests/528/
Test PASSed.

hpcugentbot · 2015-02-25T17:39:12Z

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/NCM_Components-pull_requests/529/
Test PASSed.

hpcugentbot · 2015-02-26T11:18:06Z

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/NCM_Components-pull_requests/531/
Test PASSed.

hpcugentbot · 2015-02-26T17:57:42Z

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/NCM_Components-pull_requests/532/
Test PASSed.

hpcugentbot · 2015-03-10T07:22:28Z

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/NCM_Components-pull_requests/546/
Test PASSed.

hpcugentbot · 2015-03-10T08:34:07Z

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/NCM_Components-pull_requests/547/
Test PASSed.

hpcugentbot · 2015-03-11T12:36:58Z

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/NCM_Components-pull_requests/552/
Test PASSed.

hpcugentbot · 2015-03-12T17:53:27Z

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/NCM_Components-pull_requests/553/
Test PASSed.

hpcugentbot · 2015-03-13T16:24:48Z

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/NCM_Components-pull_requests/554/
Test PASSed.

ned21 · 2015-03-13T20:37:40Z

ncm-systemd/src/main/perl/Systemd/Service.pm

+    sshd => 1,
+);
+
+Readonly my $BASE => "/software/components/systemd";


Use $self->prefix instead as this then allows module "aliasing"

@ned21 what do you mean with aliasing?

See quattor/ncm-ncd#11

hmm, it makes things complicated on my end as Systemd::Service is not a component. i'll have to think about this.

the current usage i have in mind is to use unmodified ncm-chkconfig profiles under EL7 by including the following template in EL7:
https://github.com/stdweird/configuration-modules-core/blob/systemd/ncm-systemd/src/main/pan/components/systemd/legacy/chkconfig.pan

it sets an alias on ncm-chkconfig for a partial ncm-systemd, namely the part of ncm-systemd that deals with services. (ncm-systemd will also be able to do e.g. unit configuration, the equivalent of current ncm-sysconfig).

jouvin · 2015-03-14T12:06:45Z

Could we merge this one (with or without @ned21 suggested change) to allow give it some early exposure for those starting to look at EL7. I think this is in line with Grenoble discussion. As it is still not use in any part of the template library, it is harmless if the component is not yet rock solid. We may add a disclaimer in the doc that this is an early/beta version and that many things are subject to change in the next release, including the schema... What do you think?

stdweird · 2015-03-15T09:23:34Z

@jouvin i'd like things reviewed before merged in. i also found that the possible_missing work is not sufficient, so expect a few more commits. people who want to work with ncm-systemd can build there own package (15.4 is only 1.5 months away btw).

jouvin · 2015-03-15T09:26:23Z

Ok, as you prefer. As I said, personnally I don't mind putting a beta version of a new component (not an existing one!) in a release if we manage to put a disclaimer somewhere...

hpcugentbot · 2015-03-15T14:58:36Z

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/NCM_Components-pull_requests/561/
Test PASSed.

hpcugentbot · 2015-03-15T15:59:45Z

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/NCM_Components-pull_requests/562/
Test PASSed.

hpcugentbot · 2015-03-15T16:27:30Z

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/NCM_Components-pull_requests/563/
Test PASSed.

hpcugentbot · 2015-03-16T08:38:57Z

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/NCM_Components-pull_requests/564/
Test PASSed.

hpcugentbot · 2015-03-25T13:05:40Z

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/NCM_Components-pull_requests/576/
Test PASSed.

hpcugentbot · 2015-03-25T17:57:04Z

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/NCM_Components-pull_requests/594/
Test PASSed.

… but has an active unit that it is triggeredby, is considered active.

hpcugentbot · 2015-03-26T13:56:01Z

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/NCM_Components-pull_requests/596/
Test PASSed.

stdweird · 2015-03-26T14:02:48Z

current state: we run this in production as pure replacement for ncm-chkconfig using nothing more then

include 'components/systemd/legacy/chkconfig';

in the
config/core/base for centos7 os

and a modification to the structure_component type in the the core quattor/schema

    "ncm-module"        ? string with match(SELF, '^([a-zA-Z_]\w*(?:::[a-zA-Z_]\w*)*)$')

everything else is unmodified wrt templates and it seems to work quite ok.

stdweird · 2015-03-26T14:09:51Z

see quattor/template-library-core#63 for the schema change

hpcugentbot · 2015-03-26T16:05:48Z

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/NCM_Components-pull_requests/597/
Test PASSed.

jrha · 2015-04-17T12:44:24Z

I really want this in 15.4, I'll try and find some time to sit down and go through the code, but the more reviewers the better!

ned21 · 2015-04-19T12:07:37Z

ncm-systemd/src/main/perl/Systemd/Service.pm

+    #   they do show up in list-units --all
+    #     even when only chkconfig --add is used
+    #   systemctl mask removes it from the output of chkconfig --list
+    #   systemctl umask restores it to last known state


umask => unmask

ned21 · 2015-04-19T12:29:47Z

The code looks OK although I am not sure it will give very useful output in NoAction mode without the "list" commands to provide data to work with. I don't know anything about systemd to conclude whether this is the "right" way to implement this but I guess the schema and use of the component was reviewed at the workshop?

stdweird · 2015-04-30T06:06:42Z

@ned21
wrt NoAction, without any list data, it's pretty much useless.
the component was presented at the workshop, the schema briefly reviewed. main target use for now is to use the configuration from existing /software/components/chkconfig. i guess when people will actually use it, we'll see how it goes.
what do you want to know about systemd wrt the "right" way? main i can provide some further info.

…rmless (i.e. that only query for iniformation, not for making changes)

…ist to avoid unnecessary warnings

hpcugentbot · 2015-04-30T07:16:38Z

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/NCM_Components-pull_requests/663/
Test PASSed.

jouvin · 2015-04-30T12:29:57Z

I'm trying to use ncm-systemdbut when I include the chkconfig compatibility, I get the following error:

     [panc] validation error [/scratch/jouvin/quattor/cdb/cfg/clusters/lal/service-machines-test/profiles/tracsrv2.lal.in2p3.fr.pan]
     [panc] record definition contains unexpected field(s): ncm-module 
     [panc] element path: '/software/components/chkconfig'
     [panc] type: 'component_chkconfig_type' [/scratch/jouvin/quattor/cdb/cfg/quattor/15.4.0-dev/components/chkconfig/schema.pan:67.33-71.1]
     [panc] path '/software/components/chkconfig' bound to type component_chkconfig_type in [/scratch/jouvin/quattor/cdb/cfg/quattor/15.4.0-dev/components/chkconfig/schema.pan:73.41-73.64]

Do I need an updated schema?

stdweird · 2015-04-30T13:35:24Z

@jouvin yes, you need https://github.com/quattor/template-library-core/blob/master/quattor/types/component.pan#L22

jouvin · 2015-04-30T16:31:21Z

Works like a charm :) Thanks for this very useful contribution. I'll add the suggested include as part of the base EL7 config in the template library: this will make the transition very easy.

As far as I'm concerned, I think it is ready for merging.

jrha · 2015-04-30T17:03:53Z

Agreed.

jouvin · 2015-05-05T12:50:36Z

Were @ned21's comments about keepstataddressed (#424 (diff))? If yes, I am ready to merge it. We'll open issues when they arise...

stdweird · 2015-05-05T13:03:50Z

@jouvin yes, the second last commit should do that

ncm-systemd: initial support for systemd unit control

jrha added this to the 15.4 milestone Feb 26, 2015

stdweird force-pushed the systemd branch from e94bdc9 to c78d9d7 Compare March 10, 2015 07:03

ned21 reviewed Mar 13, 2015
View reviewed changes

jouvin modified the milestones: 15.2, 15.4 Mar 14, 2015

stdweird force-pushed the systemd branch from 382a6dd to dd5dc11 Compare March 15, 2015 14:50

stdweird changed the title ~~ncm-systemd: initial supprt for systemd unit control~~ ncm-systemd: initial support for systemd unit control Mar 16, 2015

jrha modified the milestones: 15.4, 15.2 Mar 17, 2015

stdweird added 3 commits March 25, 2015 13:37

add systemd config and schema

dd3fa88

add initial systemd component module

d8b081f

add initial unittests and test data

d6de327

stdweird force-pushed the systemd branch from af1a32d to 70382bb Compare March 25, 2015 12:57

Add more systemd array properties (incl Triggers/TriggeredBy)

24b055c

stdweird added 2 commits March 26, 2015 14:44

Bump build-tools

03d8bba

Add check for active triggeredby units, now any unit that is inactive…

6e26ea7

… but has an active unit that it is triggeredby, is considered active.

Do a fill_cache on the triggeredby units

8e87ee1

ned21 reviewed Apr 19, 2015
View reviewed changes

stdweird added 2 commits April 30, 2015 08:32

Use keeps_state with CAF::Process for commands that are considered ha…

66c732d

…rmless (i.e. that only query for iniformation, not for making changes)

Service gather_current_units add chkconfig units to the limit_units l…

597104f

…ist to avoid unnecessary warnings

jouvin added a commit that referenced this pull request May 5, 2015

Merge pull request #424 from stdweird/systemd

25fcd4a

ncm-systemd: initial support for systemd unit control

jouvin merged commit 25fcd4a into quattor:master May 5, 2015

ncm-systemd: initial support for systemd unit control #424

ncm-systemd: initial support for systemd unit control #424

Conversation

stdweird commented Feb 25, 2015

stdweird commented Feb 25, 2015

stdweird commented Feb 25, 2015

hpcugentbot commented Feb 25, 2015

hpcugentbot commented Feb 25, 2015

hpcugentbot commented Feb 26, 2015

hpcugentbot commented Feb 26, 2015

hpcugentbot commented Mar 10, 2015

hpcugentbot commented Mar 10, 2015

hpcugentbot commented Mar 11, 2015

hpcugentbot commented Mar 12, 2015

hpcugentbot commented Mar 13, 2015

ned21 Mar 13, 2015

Choose a reason for hiding this comment

stdweird Mar 15, 2015

Choose a reason for hiding this comment

ned21 Mar 15, 2015

Choose a reason for hiding this comment

stdweird Mar 15, 2015

Choose a reason for hiding this comment

jouvin commented Mar 14, 2015

stdweird commented Mar 15, 2015

jouvin commented Mar 15, 2015

hpcugentbot commented Mar 15, 2015

hpcugentbot commented Mar 15, 2015

hpcugentbot commented Mar 15, 2015

hpcugentbot commented Mar 16, 2015

hpcugentbot commented Mar 25, 2015

hpcugentbot commented Mar 25, 2015

hpcugentbot commented Mar 26, 2015

stdweird commented Mar 26, 2015

stdweird commented Mar 26, 2015

hpcugentbot commented Mar 26, 2015

jrha commented Apr 17, 2015

ned21 Apr 19, 2015

Choose a reason for hiding this comment

ned21 commented Apr 19, 2015

stdweird commented Apr 30, 2015

hpcugentbot commented Apr 30, 2015

jouvin commented Apr 30, 2015

stdweird commented Apr 30, 2015

jouvin commented Apr 30, 2015

jrha commented Apr 30, 2015

jouvin commented May 5, 2015

stdweird commented May 5, 2015