ncm-sudo: Fix generation of parameter lists #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than zero or more, as no whitespace would be invalid.
And get rid of all the damn tabs
As specified in the man page. AFAIK tabs have never been an acceptable delimeter for parameter lists. To test this, modify the all_options test to test parameter lists including an option of each type. Fixes quattor#460.
|
Refer to this link for build results (access rights to CI server needed): |
Anything else is invalid syntax
|
Refer to this link for build results (access rights to CI server needed): |
| } | ||
| foreach my $o (INT_OPTS, STRING_OPTS) { | ||
| $ln .= "$o=" . $opts{$o}->getValue . "," | ||
| if defined $opts{$o}; |
|
@jrha minor remarks, looks OK |
This makes the generation of boolean and string options more similar. Also add missing indent in logic of string options.
|
Thanks! |
|
Refer to this link for build results (access rights to CI server needed): |
|
@jrha LGTM |
ned21
added a commit
that referenced
this pull request
Apr 9, 2015
ncm-sudo: Fix generation of parameter lists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifying multiple options was possible, but untested by the unit tests, the delimiter was incorrectly specified as a tab character rather than a comma.
Fixes #460 as reported by @drossy.