ncm-hostsfile: merge config-{common,rpm} into config.pan #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| prefix '/software/components/${project.artifactId}'; | ||
|
|
||
| 'active' ?= false; | ||
| 'dispatch' ?= false; |
There was a problem hiding this comment.
Previously this was true (and for active). version has been dropped too: this is what causes ncm-cdispd to re-run the component when the rpm is updated.
ajf8
force-pushed
the
ncm_hostsfile_squash_config
branch
from
d550a62
to
ba97629
Compare
|
LGTM |
ajf8
force-pushed
the
ncm_hostsfile_squash_config
branch
from
ba97629
to
b5f8a75
Compare
ajf8
force-pushed
the
ncm_hostsfile_squash_config
branch
from
b5f8a75
to
d1d6449
Compare
|
also LGTM. |
jrha
added a commit
that referenced
this pull request
Dec 2, 2015
ncm-hostsfile: merge config-{common,rpm} into config.pan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another one of these, the last one for now hopefully :)