Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ncm-sudo: add boolean option 'visiblepw' to ncm-sudo. #817

Merged
merged 1 commit into from Jul 25, 2016
Merged

ncm-sudo: add boolean option 'visiblepw' to ncm-sudo. #817

merged 1 commit into from Jul 25, 2016

Conversation

bmcann
Copy link
Contributor

@bmcann bmcann commented Jul 18, 2016 •
edited

  • The configurable 'visiblepw' is a default setting in the /etc/sudoers file as installed via the RPM in Scientific Linux 5,6&7.
  • Having this option added to ncm-sudo will allow a system administrator to reconstruct the /etc/sudoers file if they so wished. This is currently not possible.
  • This should not introduce any incompatibility, it is a simple enhancement.

@hpcugentbot
Copy link

Automatic reply from Jenkins: Can I test this?

@bmcann bmcann changed the title Add boolean option 'visiblepw' to ncm-sudo. ncm-sudo: add boolean option 'visiblepw' to ncm-sudo. Jul 18, 2016
@stdweird stdweird added this to the 16.8 milestone Jul 18, 2016
@stdweird
Copy link
Member

LGTM

@ned21
Copy link
Contributor

ned21 commented Jul 18, 2016

Test this please

@bmcann
Copy link
Contributor Author

bmcann commented Jul 22, 2016

Thanks folks. I know this is short notice, but can this make 16.6?

@jrha
Copy link
Member

jrha commented Jul 22, 2016

Tested at RAL?

Add boolean option 'visiblepw' to ncm-sudo.
115260d 
- This is a default option that is set to false in the /etc/sudoers file
  as it is installed from RPM in Scientific Linux 5,6,7. Having this
  option will enable an admin to reconstruct the default configuration
  with ncm-sudo if they so wished.
@stdweird
Copy link
Member

test this please

@stdweird
Copy link
Member

Test this please

@stdweird
Copy link
Member

@ned21 fixed the test message on jenkins side.

@bmcann
Copy link
Contributor Author

bmcann commented Jul 25, 2016 •
edited

@jrha, I've just tested this at RAL and the code behaves as expected.

If I set: '/software/components/sudo/general_options/1/options' = dict('visiblepw', false);, I get: Defaults !visiblepw

If I set: '/software/components/sudo/general_options/1/options' = dict('visiblepw', true);, I get: Defaults visiblepw

and if I don't set anything, no entry for Defaults (!)visiblepw appears in /etc/sudoers

@stdweird
Copy link
Member

@jrha after the confirmation, i'm okay with merging this in for 16.6

@jrha jrha modified the milestones: 16.6, 16.8 Jul 25, 2016
@jrha jrha merged commit 82dabfc into quattor:master Jul 25, 2016
@jrha
Copy link
Member

jrha commented Jul 25, 2016

Thanks @brunocanning!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
16.6
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bmcann @hpcugentbot @stdweird @ned21 @jrha