Test::Quattor::Critic: add Perl::Critic whitelist testing #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
also, please don't make any comments on what critic policies we should add and what not. if you want certain tests, open a PR, set a milestone and check your agenda when you have time to fix the fallout |
|
🙈 |
|
The perltidy test is way too difficult to tune, and perltidy has no support for whitelisting. You are advised to look at the output and we should discuss final parameters and possible impact in followup PRs |
stdweird
force-pushed
the
critic
branch
3 times, most recently
from
703dcf8
to
f901498
Compare
…riter/Reader cannot be used for testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds an informational
perltidytestRequires #114