Allow to create label on vfat type

[aka7]

Fix label option for mkfs.vfat so that vfat type can also have label. mkfs.vfat does not have -L option, instead has -n.

fixes: #102

[aka7]

open to any other suggestion on this.

[ned21]

yeah, I can see why you have done it this way, a hash like TUNECMDS doesn't make much sense when only one FS type has a different value. The construct you really want is a switch with default option, which I guess should be supported in the version of perl on EL6? But constants can't be dynamic...

What I think you want to do here is replace the MKFSLABEL constant with a function which accepts a string of $fstype and then something like this:

for ($fstype) {
    $mkfs_label = '-n' when /^vfat$/;
    default { $mkfslabel = '-L' }
}
return $mkfs_label;

which can be called cleanly and as a near drop-in replacement for MKFSLABEL.
my @opts = exists $self->{label} ? (mkfs_label($self->{type}), $self->{label}):();

[aka7]

yeah, I can see why you have done it this way, a hash like TUNECMDS doesn't make much sense when only one FS type has a different value. The construct you really want is a switch with default option, which I guess should be supported in the version of perl on EL6? But constants can't be dynamic...

What I think you want to do here is replace the MKFSLABEL constant with a function which accepts a string of $fstype and then something like this:

for ($fstype) {
    $mkfs_label = '-n' when /^vfat$/;
    default { $mkfslabel = '-L' }
}
return $mkfs_label;

which can be called cleanly and as a near drop-in replacement for MKFSLABEL. my @opts = exists $self->{label} ? (mkfs_label($self->{type}), $self->{label}):();

thanks, but I think what I've done now seems more better approach? Credit Trevor Carden.