Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

El8 support #209

Merged
merged 2 commits into from Dec 22, 2021
Merged

El8 support #209

merged 2 commits into from Dec 22, 2021

Conversation

jouvin
Copy link
Contributor

@jouvin jouvin commented Oct 27, 2021 •
edited

  • Add the missing template for AII KS
  • Ensure that the ncm-spma version used is the one configured, if the default version was changed (.e.g. for testing)

stdweird
stdweird reviewed Oct 27, 2021
View reviewed changes
quattor/client/rpms.pan Outdated Show resolved Hide resolved
@jouvin
Quattor client RPMs: allow to force a non-default version of ncm-spma
e2105c0 
- If ncm-spma is included before configuring the Quattor client, keep the version used
@jouvin
Copy link
Contributor Author

jouvin commented Oct 27, 2021

syntax_check test fails to run but checking with panlint locally, the template is passing the tests.

@jrha jrha added this to the 22.2 milestone Dec 20, 2021
@jouvin
Copy link
Contributor Author

jouvin commented Dec 20, 2021

I checked with pan_indent_checker too in the source branch of this PR and cannot see any problem:

git diff --name-only HEAD^ | grep '\.pan$' | xargs -r /exp/si/jouvin/GitRepositories/Quattor/Pan-Indenter/pan_indent_checker.py  check

Not sure why the test crashed and I don't see how to rerun it...

@jrha jrha merged commit 2a38f13 into quattor:master Dec 22, 2021
@jrha jrha modified the milestones: 22.2, 21.12 Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stdweird stdweird stdweird left review comments

@jrha jrha jrha approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
21.12
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jouvin @jrha @stdweird