New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing types required to support aquilon #70
Conversation
Refer to this link for build results (access rights to CI server needed): |
"timeout" ? long | ||
"actions" ? string[] with is_action_list(SELF) | ||
}; | ||
type structure_events = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
newline
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
"services" ? structure_services{} | ||
"personality" ? structure_personality | ||
"host_environment" ? string | ||
"features" ? nlist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gombasg I can't find /system/features
used in our hosts, was it moved to metadata and this got left behind?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/system/features is used to pass parameters to features. So parameter "bar" for feature "foo" will end up like "/system/features/foo/bar" = ...
test this please |
Refer to this link for build results (access rights to CI server needed): |
test this please |
Refer to this link for build results (access rights to CI server needed): |
@@ -17,6 +17,13 @@ type structure_export = { | |||
type structure_cluster = { | |||
"name" : string | |||
"type" ? string | |||
"resources" ? structure_resources |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
structure_resources
used before defined
test this please |
Refer to this link for build results (access rights to CI server needed): |
@jrha you have the doubtful honour to test new template tests for this repo. run the following until no errors occur. rm -Rf build_temp
mkdir -p build_temp/monitoring/lemon
echo "object template test;" > build_temp/test.pan
echo "declaration template monitoring/lemon/schema; type structure_monitoring = {};" > build_temp/monitoring/lemon/schema.pan
find pan -type f ! -regex '^./build_temp/.*' -name *.pan | xargs sed -n "s/^declaration[ ]\+template[ ]\+\(.*\);/include '\1';/p" >> build_temp/test.pan
find . -type f ! -regex '^./pan/.*' ! -regex '^./build_temp/.*' -name *.pan | xargs sed -n "s/^declaration[ ]\+template[ ]\+\(.*\);/include '\1';/p" >> build_temp/test.pan
find . -type f ! -regex '^./build_temp/.*' -name *.pan | xargs sed -n "s/^\(unique[ ]\+\)\?template[ ]\+\(.*\);/include '\2';/p" >> build_temp/test.pan
panc --output-dir build_temp --include-path .:build_temp build_temp/test.pan |
🙊 I accept the "honour". |
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
Btw. there are ideas to ship the schema of broker-generated data with the broker itself. Right now, if we want to export more data from the broker, that means templates need to be updated first, and the scheduling of changes can be problematic sometimes. But letting the broker export the schema would work only if there was a proper way of extending/subclassing/inheriting from existing types. Otherwise, we'd end up having to use |
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
type structure_system_aquilon = { | ||
"advertise_status" ? boolean | ||
"archetype" ? structure_archetype | ||
"build" ? string with match (SELF, 'build|blind|ready|failed|install') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stricter regexp ^(build|blind|ready|failed|install)$
Refer to this link for build results (access rights to CI server needed): |
Split aquilon system properites into seperate type Move structure_resources to before it is used Move structure_fsdata before first usage
Refer to this link for build results (access rights to CI server needed): |
@stdweird are you happy with this now? |
yes, tests fail due to something else. i'll merge this. |
Add missing types required to support aquilon
We've been carrying these in an aquilon branch in the repository up until now, the recent restructuring of the schema forced me to look at integrating this again.