Argus: allow workarounds for performance issues #134
Conversation
|
The actual changes can be seen here (by appending "?w=1" to the URL) |
| #PEPD_LIBDIR="/var/lib/argus/pepd/lib" | ||
| #PEPD_ENDORSEDDIR="/var/lib/argus/pepd/lib/endorsed" | ||
| #PEPD_PROVIDEDDIR="/var/lib/argus/pepd/lib/provided" | ||
| #PEPD_PID="/var/run/argus-pepd.pid" |
There was a problem hiding this comment.
Why add do many commented out lines?
There was a problem hiding this comment.
I just copied the original configuration file, so that the changes reflect what someone might do if doing the changes manually. I can remove them if needed.
There was a problem hiding this comment.
It doesn't add any value to ship configuration that doesn't do anything, so remove them.
| # PEP Configuration | ||
| #----------------------------------------------------------------------------- | ||
|
|
||
| variable PEP_CONFIG_FILE = PEP_HOME + '/conf/pepd.ini'; |
There was a problem hiding this comment.
metaconfig and tiny? and a structure template for the defaults?
|
As this PR improves the situation compared to what existed before, I'd suggest merging it and opening an issue for using metaconfig rather than filecopy... |
|
I'll try to improve this, but probably not before the 15.4 milestone. |
|
Agreed, it can go in as it is, but it would be great to clean it up for the next release. |
Argus: allow workarounds for performance issues
These changes are necessary for the suggested workarounds.