Synchronize Puppet DPM with UMD-3

[Pansanel]

This PR contains several changes based on the UMD-3 branch for the configuration of DPM with Puppet.

[jouvin]

@Pansanel please could you provide a short description of this PR goal. It also seems that you need to rebase your branch on the last umd-4 master... Checking the check results, panlint also has one complaint but for some reason it is not reported as an error...

[Pansanel]

@jouvin : concerning the panlint issue, I do not know how to cut the command properly.

[sartiran]

Hi Jerome,
I'm comparing these files with those at GRIF and it seems to me that they are not yet completely up to date.
Maybe I should make a PR using GRIF umd-4 templates as reference?

[Pansanel]

Can you send me the files? I will test it on our infra and include in the PR. It will be more simple.

[sartiran]

Hi,

the files are already committed on my fork

sartiran@7c1328d

I can proceed with the PR if you want.

[jouvin]

@sartiran I suggest that you open a PR with your files and that we close this one in this case, this is probably the easiest...

[Pansanel]

@sartiran : additional question: by default the 'puppet' package is installed. In the case of puppet v4 and v5, it should be puppet-agent, isn't it?

[sartiran]

puppet-agent provides puppet >= 4.0.0 so "yum install puppet" installs the puppet-agent package for versions 4 and 5

[Pansanel]

You are right, it works fine :-) If the changes are fine for you, can we merge the PR?

[sartiran]

Let me just double-check that this corresponds with what is in sartiran@7c1328d

[sartiran]

OK. It seems all ok to me.

[Pansanel]

Can you merge the pull request?

[sartiran]

I do not think the above question is for me. But in case: no, I do not have the rights to merge the PR

[jouvin]

I can merge it but @Pansanel I'd like that you rebase it on the last umd-4 upstream branch first. Would be good if @sartiran you could approve the request (I guess you have the right to do so, else we should give it to you...).

[jouvin]

@sartiran you may have the right to merge it but the problem is that nobody approved it and it is a requirement for merging it (if you are not an admin).

[sartiran]

The PR I've done yesterday is the same #217 upstreams the same files and should be up to date with the umd-4 branch. Maybe we can merge that one

[jouvin]

@sartiran @Pansanel I let you decide which PR is the most complete. Just approve the one you choose and close the other one. Then we can merge the selected one.

[Pansanel]

Alright. I will merge #217 and rebase on head :-)

[Pansanel]

I have rebased my branch and verified the modifications.

[jouvin]

@sartiran @Pansanel What is the status with this PR? It would be good to have it in 18.9...

[Pansanel]

All requested modifications have been done. We could merge this PR. @sartiran can you verify and merge?

[sartiran]

Looks good to me but I do not seem to have the right to approve the request (I've added a review... but I do not see effects)

[jrha]

Thanks!