This repository has been archived by the owner on Apr 5, 2024. It is now read-only.
Meteor 3 - wip #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- missing to really migrate schema usage of collection (from collection2)
- https://github.com/Meteor-Community-Packages/meteor-collection2/pull/443/files#diff-1bc97b15b1e837743f590899c1c0fd36eab5a1bf21df692490899220dca7b160 We still need to decide if we want to bring all the tests and support multiple versions of Meteor, probably only Meteor 3 support would be better
- Compatible with Meteor 3.0 (hooks and helpers are still not supported tho) - Removes `definition` option (and types)
…/meteor-collection2/tree/master/tests - Skipped eslint checks - We still need to run the client tests but server is running fine (we removed a few as they were trying to test dummy stuff (like default options) but modifying the collection2 class object (our goal is to run this test in our repo https://github.com/Meteor-Community-Packages/meteor-collection2/actions/runs/6398509589/job/17368820251)
denihs
reviewed
Mar 13, 2024
.versions
Outdated
| retry@1.1.1-alpha300.18 | ||
| routepolicy@1.1.2-alpha300.18 | ||
| socket-stream-client@0.5.2-alpha300.18 | ||
| tmeasday:check-npm-versions@1.0.2 |
There was a problem hiding this comment.
This package had Typescript pinned in version 4. Beta 6 updated Typescript to version 5. This is causing a conflict, and currently, it's possible to use this package with Beta 6.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks