Merge pull request #3 from alisnic/fix/no-fibers-future-import

Fix fibers/future import check
quavedev · Feb 20, 2024 · 5910824 · 5910824
2 parents 05667aa + ffa81dd
commit 5910824
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/lib/rules/no-fibers-future-usage.js b/lib/rules/no-fibers-future-usage.js
@@ -90,8 +90,7 @@ const isUsingFibersMethods = (node) => {
 };
 
 const includesFibersOrFuturePath = (toTest) => toTest &&
-  typeof toTest === "string" &&
-  ["fibers", "future"].some((t) => toTest.toLowerCase().includes(t));
+  typeof toTest === "string" && toTest.toLowerCase().startsWith('fibers')
 
 const isImportingFibersOrFuture = (node) => {
   const isImportDeclaration = node &&

diff --git a/package.json b/package.json
@@ -12,7 +12,7 @@
     "rule": "node scripts/new-rule.js",
     "test": "npm run unit-test && npm run coverage:report && npm run coverage:check",
     "unit-test": "nyc --reporter=lcov mocha tests --recursive",
-    "unit-test:watch": "npm run unit-test -s -- --watch -g no-sync-mongo-methods-on-server"
+    "unit-test:watch": "npm run unit-test -s -- --watch"
   },
   "files": [
     "README.md",

diff --git a/tests/lib/rules/no-fibers-future-usage.js b/tests/lib/rules/no-fibers-future-usage.js
@@ -23,6 +23,7 @@ ruleTester.run('no-fibers-future-usage', rule, {
     { code: 'const aa = new Test()' },
     { code: 'Testing(function() {})' },
     { code: 'User.current' },
+    { code: "import isFuture from 'date-fns/isFuture'" }
   ],
 
   invalid: [
@@ -32,6 +33,12 @@ ruleTester.run('no-fibers-future-usage', rule, {
         { message: 'Invalid import/require of Fibers/Future', type: 'ImportDeclaration' },
       ],
     },
+    {
+      code: 'import Fibers from "fibers"',
+      errors: [
+        { message: 'Invalid import/require of Fibers/Future', type: 'ImportDeclaration' },
+      ],
+    },
     {
       code: 'require("fibers/future")',
       errors: [