updater: minimize vulns' lock duration in the NVD metadata fetcher

quay · Nov 18, 2016 · 1c3daa2 · 1c3daa2
1 parent e38b67a
commit 1c3daa2
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/updater/metadata_fetchers/nvd/nvd.go b/updater/metadata_fetchers/nvd/nvd.go
@@ -105,14 +105,15 @@ func (fetcher *NVDMetadataFetcher) AddMetadata(vulnerability *updater.Vulnerabil
 
 	if nvdMetadata, ok := fetcher.metadata[vulnerability.Name]; ok {
 		vulnerability.Lock.Lock()
-		defer vulnerability.Lock.Unlock()
 
 		// Create Metadata map if necessary.
 		if vulnerability.Metadata == nil {
 			vulnerability.Metadata = make(map[string]interface{})
 		}
 
 		vulnerability.Metadata[metadataKey] = nvdMetadata
+
+		vulnerability.Lock.Unlock()
 	}
 
 	return nil