cicd: fix nightly-ci error

This fixes the nightly-ci workflow and adds a means to lint and validate
the workflow files.

Signed-off-by: Hank Donnay <hdonnay@redhat.com>

.github/workflows/.gitignore

@@ -0,0 +1,3 @@
+yq
+yajsv
+*.json-schema

.github/workflows/.yamllint.yml

@@ -0,0 +1,6 @@
+---
+extends: default
+rules:
+  line-length: false
+  truthy:
+    check-keys: false

.github/workflows/Makefile

@@ -0,0 +1,19 @@
+check: github-workflow.json-schema yajsv yq
+	for f in *.yml; do ./yq -o json "$$f" > "$${f%yml}json"; done
+	./yajsv -s $< *.json
+	rm *.json
+	command -v yamllint >/dev/null 2>&1 && yamllint .
+
+clean:
+	rm -rf yq yajsv github-workflow.json-schema
+
+.PHONY: check clean
+
+yq:
+	cd /tmp && GOBIN=$(PWD) go install github.com/mikefarah/yq/v4@latest
+
+yajsv:
+	cd /tmp && GOBIN=$(PWD) go install github.com/neilpa/yajsv@latest
+
+github-workflow.json-schema:
+	curl -sSLf https://github.com/SchemaStore/schemastore/raw/master/src/schemas/json/github-workflow.json > $@

.github/workflows/config-ci.yml

@@ -25,7 +25,7 @@ jobs:
         run: |
           echo 'go_versions=["1.20", "1.19"]' >> "$GITHUB_OUTPUT"
 
-  commit-check: 
+  commit-check:
     name: Commit Check
     runs-on: ubuntu-latest
     steps:

.github/workflows/nightly-ci.yaml → .github/workflows/nightly-ci.yml

@@ -21,7 +21,6 @@ jobs:
     name: Integration Tests
     needs: ['config']
     runs-on: ubuntu-latest
-    env:
     services:
       # These will be used by a container on the same docker network, so no need to expose ports.
       postgres:
@@ -62,7 +61,7 @@ jobs:
         with:
           platforms: linux/${{ matrix.platform }}
       - name: Make directories on cache miss
-        run: mkdir -p "$(go env GOMODCACHE)" "$(go env GOCACHE)" 
+        run: mkdir -p "$(go env GOMODCACHE)" "$(go env GOCACHE)"
         if: ${{ ! steps.cache.outputs.cache-hit }}
       - name: Configure RabbitMQ
         run: |

.github/workflows/prepare-release.yml

@@ -39,7 +39,7 @@ jobs:
           filter_tag="--tag-filter-pattern v4"
           branch=${{ github.event.inputs.branch }}
           echo "discovered branch $branch"
-          if [[ ${branch%-*} == "release" ]]; then 
+          if [[ ${branch%-*} == "release" ]]; then
             filter_tag="--tag-filter-pattern v${branch#release-}"
           fi
 

.github/workflows/v2-issues.yml

@@ -1,3 +1,4 @@
+---
 name: 'Manage v2 Issues'
 on:
   workflow_dispatch: