Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contrib/analyze-local-image pollutes /tmp #117

Closed
abulimov opened this issue Mar 23, 2016 · 1 comment
Closed

contrib/analyze-local-image pollutes /tmp #117

abulimov opened this issue Mar 23, 2016 · 1 comment
Labels
kind/bug things are not as they seem

Comments

@abulimov
Copy link

As os.Exit() in go skips all deferred instructions, the statement defer os.RemoveAll(path) on line 116 gets executed only when our image has visible vulnerabilities.

So almost every time this tool is used the temporary directory /tmp/analyze-local-image-* remains.
@Quentin-M
Copy link
Contributor

Good catch!

@Quentin-M Quentin-M added kind/bug things are not as they seem component/contrib labels Mar 23, 2016
Quentin-M added a commit that referenced this issue Mar 23, 2016
@Quentin-M
contrib: Use return instead of os.Exit(1) in analyze-local-images
98301c1 
In order to cleanup properly the allocated resources (`defer`).

Fixes #117
@Quentin-M Quentin-M mentioned this issue Mar 23, 2016
Merged
Quentin-M added a commit that referenced this issue Mar 24, 2016
@Quentin-M
contrib: Use return instead of os.Exit(1) in analyze-local-images
1040dbb 
In order to cleanup properly the allocated resources (`defer`).

Fixes #117
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug things are not as they seem
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Quentin-M @abulimov