contrib: Use return instead of os.Exit(1) in analyze-local-images
#118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL |
jzelinskie
added
area/dev tooling
|
Ideally the program should exit non-zero on failure. You should pull out everything that isn't flags into a function and let it return an error, we can get a proper exit code. |
jzelinskie
added
reviewed/needs rework
In order to cleanup properly the allocated resources (`defer`). Fixes #117
Quentin-M
force-pushed
the
cleanup_contrib
branch
from
98301c1
to
1040dbb
Compare
Quentin-M
added
lacking/review
|
PTAL |
|
LGTM |
jzelinskie
added
reviewed/lgtm
and removed
lacking/review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to cleanup properly the allocated resources (
defer).Note that we still use os.Exit(1) for command line errors.
Fixes #117