Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[notifier] api/v1/notification returns contentType: text/plain when application/json is expected #1523

Closed
mieliespoor opened this issue Mar 14, 2022 · 0 comments · Fixed by #1599
Closed

[notifier] api/v1/notification returns contentType: text/plain when application/json is expected #1523

mieliespoor opened this issue Mar 14, 2022 · 0 comments · Fixed by #1599
Assignees
@hdonnay
Labels
triaged The maintainers have seen this issue

Comments

@mieliespoor
Copy link

Description of Problem / Feature Request

The api call /notifier/api/v1/notification/{id} returns with Content-Type: text/plain where application/json is expected. Even if we specify the application/json in the accept header, we still get a plain text response. Would be great if this could be fixed in the upcoming 4.4 release.

Expected Outcome

Content-Type: application/json

Actual Outcome

Content-Type: text/plain

Environment

N/A

  • Clair version/image: 4.3.5
  • Clair client name/version:
  • Host OS: Docker Container on AWS ECS
@hdonnay hdonnay added the triaged The maintainers have seen this issue label Jun 16, 2022
@hdonnay hdonnay self-assigned this Jun 16, 2022
hdonnay added a commit to hdonnay/clair that referenced this issue Jul 7, 2022
@hdonnay
httptransport: update notification endpoints
8b33722 
This updates the notification endpoints to be more in-line with the
new all-in-one, interally instrumented handler style. It also includes
a change for making the instrumentation code less verbose.

Closes: quay#1523
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay hdonnay linked a pull request Jul 7, 2022 that will close this issue
httptransport: notification content type, etc #1599
Merged
hdonnay added a commit to hdonnay/clair that referenced this issue Jul 22, 2022
@hdonnay
httptransport: update notification endpoints
aabadec 
This updates the notification endpoints to be more in-line with the
new all-in-one, interally instrumented handler style. It also includes
a change for making the instrumentation code less verbose.

Closes: quay#1523
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hdonnay hdonnay

Labels
triaged The maintainers have seen this issue
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

httptransport: notification content type, etc hdonnay/clair
2 participants
@hdonnay @mieliespoor