Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to trace requests though logs #1547

Closed
paulaldridge opened this issue Apr 11, 2022 · 0 comments · Fixed by #1661
Closed

Unable to trace requests though logs #1547

paulaldridge opened this issue Apr 11, 2022 · 0 comments · Fixed by #1661
Assignees
@hdonnay
Labels
triaged The maintainers have seen this issue

Comments

@paulaldridge
Copy link
Contributor

Description of Problem / Feature Request

Trying to debug problems using the logs is hard as there is no way to connect logs to specific requests. It would be great to have the request id (and possibly more info such as the request URI) included in the logger context so that requests are traceable.

Environment

  • Clair version/image: v4.4.0
paulaldridge added a commit to paulaldridge/clair that referenced this issue Apr 11, 2022
@paulaldridge
logger: add request id to log context for traceability
38d8aa0 
this allows requests to be traced through the logs

Fixes quay#1547
@paulaldridge paulaldridge mentioned this issue Apr 11, 2022
Closed
paulaldridge added a commit to paulaldridge/clair that referenced this issue Apr 11, 2022
@paulaldridge
logger: add request id to log context for traceability
cf97e78 
this allows requests to be traced through the logs

Fixes quay#1547

Signed-off-by: Paul Aldridge <paulaldridge@uk.ibm.com>
crozzy pushed a commit to paulaldridge/clair that referenced this issue May 18, 2022
@paulaldridge @crozzy
logger: add request id to log context for traceability
97cd37b 
this allows requests to be traced through the logs

Fixes quay#1547

Signed-off-by: Paul Aldridge <paulaldridge@uk.ibm.com>
@hdonnay hdonnay added the triaged The maintainers have seen this issue label Jun 16, 2022
@hdonnay hdonnay self-assigned this Jun 16, 2022
hdonnay added a commit to hdonnay/clair that referenced this issue Dec 6, 2022
@hdonnay
httptransport: add a request_id to logs
2a58ae4 
This re-uses any trace ID that OpenTelemetry supports, or generates a
weakly random one based on some request features.

Closes: quay#1547
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay hdonnay mentioned this issue Dec 6, 2022
Merged
hdonnay added a commit to hdonnay/clair that referenced this issue Dec 6, 2022
@hdonnay
httptransport: add a request_id to logs
f26c908 
This re-uses any trace ID that OpenTelemetry supports, or generates a
weakly random one based on some request features.

Closes: quay#1547
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
hdonnay added a commit to hdonnay/clair that referenced this issue Dec 8, 2022
@hdonnay
httptransport: add a request_id to logs
c57f214 
This re-uses any trace ID that OpenTelemetry supports, or generates a
random one.

Closes: quay#1547
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay hdonnay closed this as completed in a9228d4 Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hdonnay hdonnay

Labels
triaged The maintainers have seen this issue
Milestone
No milestone
2 participants
@hdonnay @paulaldridge