Allow specifying datastore driver by config, relocate upgrade detection, mock datastore #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if err != nil { | ||
| t.Error(err) | ||
| return | ||
| } | ||
| datastore := ds.(*pgSQL) |
There was a problem hiding this comment.
you should put this below the defer
Quentin-M
force-pushed
the
db_registration
branch
from
b5e8be9
to
f8b3b16
Compare
Quentin-M
force-pushed
the
db_registration
branch
from
f8b3b16
to
599cac4
Compare
| // Generate a pagination key if none is provided. | ||
| // TODO(Quentin-M): Move to the API code. |
There was a problem hiding this comment.
This doesn't make sense to move to the API as it is setting a default value for the config.
Quentin-M
force-pushed
the
db_registration
branch
from
599cac4
to
3f49fa4
Compare
| // If no Namespace is associated, | ||
| // - If the FeatureVersion is present in the parent layer, associate its Namespace, | ||
| // - If a Namespace has been detected in the layer, associate it, | ||
| // - Otherwise, throw an error. |
There was a problem hiding this comment.
Let's rework this comment because it's really hard to understand.
There was a problem hiding this comment.
Let's add a comment addressing the building of this map and then we'll add comments inside the next block to describe each of these cases.
// Build a map of the namespaces for each FeatureVersion in our parent layer.
Quentin-M
force-pushed
the
db_registration
branch
from
3f49fa4
to
dcf34cf
Compare
Quentin-M
force-pushed
the
db_registration
branch
from
dcf34cf
to
5080cd4
Compare
|
PTAL 🎯 |
jzelinskie
added
lacking/review
|
LGTM |
jzelinskie
added
reviewed/lgtm
and removed
lacking/review
Quentin-M
force-pushed
the
db_registration
branch
from
5080cd4
to
228cee7
Compare
Quentin-M
force-pushed
the
db_registration
branch
from
228cee7
to
836d37b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.