Add openSUSE/SLES support #199

tboerger · 2016-06-09T14:11:25Z

In order to integrate openSUSE/SLES including the available patches for CVEs I have started to work on this pull request. I already opened this pull request to get feedback early as possible. Below you can see a checklist for the remaining items.

Fetcher for openSUSE
Write tests for openSUSE fetcher
Fetcher for SLES
Write tests for SLES fetcher

Do I miss something? Should we abstract the shared functionality from RedHat and openSUSE/SLES?

Quentin-M · 2016-06-09T14:34:00Z

@hi,

This WIP is truly exciting. Thanks for contributing!

Absolutely, we should extract the OVAL parser, I believe that utils/ should be a good place for it. We would be able to test it independently
We may need new detectors to fully support openSUSE/SLES in Clair

Out of curiosity, do you know how often openSUSE/SLES base images are used?

tboerger · 2016-06-09T14:34:34Z

The official opensuse:42.1 image is a pretty good example to demonstrate that it already works with the existing worker implementation.

tboerger · 2016-06-09T14:37:26Z

Out of curiosity, do you know how often openSUSE/SLES base images are used?

I really can't tell you how often it gets used. But at least for SLES it will increase for sure. I would like to hook Clair into Portus for automated vulnerability checks.

tboerger · 2016-06-27T08:17:39Z

We've got Hackweek now at SUSE and @jordimassaguerpla wants to finish this PR.

jordimassaguerpla · 2016-06-28T11:55:25Z

I will refactor now by extracting common code first from sle and opensuse and then from redhat and suse.

jordimassaguerpla · 2016-06-30T16:19:26Z

I am going to rebase all in one commit

jordimassaguerpla · 2016-06-30T16:34:50Z

@Quentin-M : What do you think how it looks now? I am not very good with Go, so feel free to give me any advice . I still have tomorrow and can also work on that on my spare time next week.

thanks in advance

tboerger · 2016-06-30T16:51:10Z

updater/fetchers/oval/oval.go

@@ -0,0 +1,306 @@
+// Copyright 2015 clair authors


That should be part of utils and not fetcher

tboerger · 2016-06-30T16:54:46Z

The variable names are not really go-like

jordimassaguerpla · 2016-07-01T10:08:36Z

can you be more concrete on the variable names?

tboerger · 2016-07-03T23:52:31Z

can you be more concrete on the variable names?

Sure, OpenSUSE_Info should be OpenSUSEInfo, SLE_Info should be SLEInfo and so on. Separation with underscores is AFAIK pretty uncommon in Go.

tboerger · 2016-07-13T15:27:07Z

@jordimassaguerpla hopefully you can fix the remaining NITPICKing? Afterwards @Quentin-M should be happy for sure to merge it :)

tboerger · 2016-07-13T15:48:50Z

@guypod what are you talking about?

Quentin-M · 2016-07-13T15:59:17Z

@tboerger: @guypod is talking about #175, wrong thread.

guypod · 2016-07-13T16:02:08Z

Oops, my bad - too many similar looking GitHub tabs open ;)
Sorry for the noise!

Deleted my comment to avoid future confusion.

jordimassaguerpla · 2016-07-13T17:16:39Z

sure. Sorry for the delay, hackweek ended and I didn't find the time to do it.I was refactoring the rhel code to use the oval parser and that is why I had not sent it yet. I'll do it asap.

jordimassaguerpla · 2016-07-15T19:27:32Z

Hi! I just refactored everything. I extracted the oval parser from rhel and use that for suse and opensuse.
Since commiting here would be a mess, I created another PR

#218

Closing this one.

jordimassaguerpla · 2016-07-15T19:28:14Z

mm. I think can't close this one. Thomas can you?

tboerger · 2016-07-15T19:38:24Z

Why closing this one? Just rebase and squash commits? :)

jordimassaguerpla · 2016-07-15T20:49:18Z

ok :-)

Branch rebased. I am closing the other one

jordimassaguerpla · 2016-07-15T20:50:34Z

updater/fetchers/rhel/rhel.go

-	if err != nil {
-		return resp, err
-	}
-	firstRHSA, err := strconv.Atoi(flagValue)


The tests pass but this thing of getting the firstRHSA from the flagValue ... not sure If I extracted this correctly or if I even understood what this was for .... Can someone else just take a look and see if I missed something here? Thanks and sorry I if did.

This ensures that Clair doesn't try to re-parse RHSAs that have already been processed and stored - in order to make the updates faster.

jzelinskie · 2016-09-07T22:50:41Z

utils/oval/oval.go

+	var featureVersionParametersArray []database.FeatureVersion
+
+	for _, fv := range featureVersionParameters {
+		featureVersionParametersArray = append(featureVersionParametersArray, fv)


Similar to the other recommendation you can use 1 append and the splat

featureVersionParametersArray = append(featureVersionParametersArray, featureVersionParamters...)

Is there a reason you're explicitly making a copy here?

jzelinskie · 2016-09-07T23:27:15Z

Thanks for the PR! This is a really useful refactor of the oval stuff into a shared package. I mostly commented on code that was already there, but simply moved.

jordimassaguerpla · 2016-09-22T18:23:07Z

@jzelinskie : I've done all the changes you suggested.
Is there anything else?
I am leaving the commits for your revision but I will rebase once I get the "lgtm" from you or @Quentin-M

jzelinskie · 2016-09-22T21:43:41Z

Just that last tiny thing of changing the updater flag to have an underscore and then it LGTM! Thanks a bunch for all your effort, this change is awesome!

tboerger · 2016-09-22T22:03:35Z

Cool to see it's nearby getting merged 👏

We extracted oval parser from rhel and used that for opensuse and SUSE Linux Enterpise Signed-off-by: Thomas Boerger <tboerger@suse.de> Signed-off-by: Jordi Massaguer Pla <jmassaguerpla@suse.de>

jordimassaguerpla · 2016-09-23T10:00:31Z

I just did the change on the updated flag and rebased everything so it looks cleaner when you merge. Thanks a lot for taking the time to review it :) ! I am very excited to be contributing :) !

arjunm183 · 2017-07-12T19:35:34Z

Is this completed to integrate clair with SLES Updater.

jzelinskie · 2017-07-13T00:08:31Z

This change actually got reverted because I couldn't ever get an answer from SUSE's legal department about the license of the Vulnerability data.

flavio · 2017-09-15T12:30:17Z

Hello from SUSE, I'm a member of the team that wrote this PR. What kind of legal clearance are you looking for and who have you contacted?

Pinging also @msmeissn from SUSE's security team. He might be able to help with your questions about the usage of the vulnerability data.

jzelinskie · 2017-09-15T15:08:40Z

Hi @flavio
I simply need to know how the vulnerability data is licensed to be used. I sent an email to security@ and received a response from Marcus, but never got a follow up.

msmeissn · 2017-09-17T20:10:36Z

I am sorry if I failed to answer, but I got the answer from my legal department.

https://www.suse.com/de-de/support/security/oval/

The OVAL data is provided by SUSE under the Creative Commons License 4.0 with Attribution for Non-Commercial usage (CC-BY-NC-4.0).

I hope this is satisfying.

Rots · 2017-11-01T12:39:01Z

@jzelinskie, is this expected to be merged again at some point now?

flavio · 2017-11-02T11:43:01Z

@Rots clair's code changed and merging the reverted code again is not possible. I'm working on that and I'll file a PR in the next weeks (I'm a bit busy ATM).

LJosef · 2017-11-20T02:53:39Z

@flavio looking forwarding to the progress on this merging. Great appreciate!

chennanfei · 2017-11-28T11:19:21Z

Looking forwarding to the progress, too!

Payback159 · 2017-11-29T09:10:59Z

Looking forwarding to the progress, too!

maorgo · 2018-03-05T09:55:21Z

Hi,
so is open suse supported for Clair yet?

Thanks

flavio · 2018-03-05T10:23:58Z

@maorgo not yet, you have to follow #503 and #506

Quentin-M added component/fetcher labels Jun 9, 2016

jordimassaguerpla force-pushed the feature/opensuse branch 2 times, most recently from c5833fc to 7e1d26f Compare June 30, 2016 15:45

jordimassaguerpla force-pushed the feature/opensuse branch from 9bd6acf to 502ef61 Compare June 30, 2016 16:32

tboerger reviewed Jun 30, 2016
View reviewed changes

updater/fetchers/oval/oval.go

@@ -0,0 +1,306 @@

// Copyright 2015 clair authors

Copy link

Author

tboerger Jun 30, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should be part of utils and not fetcher

jordimassaguerpla force-pushed the feature/opensuse branch from 45afaf2 to ddef422 Compare July 15, 2016 20:47

jordimassaguerpla mentioned this pull request Jul 15, 2016

Integrated a fetcher for openSUSE and for SUSE Linux Enterprise #218

Closed

jordimassaguerpla reviewed Jul 15, 2016
View reviewed changes

jzelinskie reviewed Sep 7, 2016
View reviewed changes

jzelinskie added the reviewed/needs rework will be closed if review not addressed label Sep 7, 2016

jordimassaguerpla force-pushed the feature/opensuse branch 2 times, most recently from f91d1c2 to a36f994 Compare September 22, 2016 18:01

jordimassaguerpla force-pushed the feature/opensuse branch from 134e513 to b8ceb0c Compare September 23, 2016 09:57

Integrated a fetcher for openSUSE and for SUSE Linux Enterprise

b8ceb0c

We extracted oval parser from rhel and used that for opensuse and SUSE Linux Enterpise Signed-off-by: Thomas Boerger <tboerger@suse.de> Signed-off-by: Jordi Massaguer Pla <jmassaguerpla@suse.de>

jzelinskie merged commit 97347ec into quay:master Sep 23, 2016

flavio mentioned this pull request Dec 30, 2017

Reintroduce image scanning for openSUSE and SLE #503

Closed

Add openSUSE/SLES support #199

Add openSUSE/SLES support #199

Conversation

tboerger commented Jun 9, 2016 • edited Loading

Quentin-M commented Jun 9, 2016 • edited Loading

tboerger commented Jun 9, 2016

tboerger commented Jun 9, 2016

tboerger commented Jun 27, 2016

jordimassaguerpla commented Jun 28, 2016

jordimassaguerpla commented Jun 30, 2016

jordimassaguerpla commented Jun 30, 2016

tboerger Jun 30, 2016

Choose a reason for hiding this comment

tboerger commented Jun 30, 2016

jordimassaguerpla commented Jul 1, 2016

tboerger commented Jul 3, 2016

tboerger commented Jul 13, 2016

tboerger commented Jul 13, 2016

Quentin-M commented Jul 13, 2016

guypod commented Jul 13, 2016 • edited Loading

jordimassaguerpla commented Jul 13, 2016

jordimassaguerpla commented Jul 15, 2016

jordimassaguerpla commented Jul 15, 2016

tboerger commented Jul 15, 2016

jordimassaguerpla commented Jul 15, 2016

jordimassaguerpla Jul 15, 2016

Choose a reason for hiding this comment

Quentin-M Sep 7, 2016

Choose a reason for hiding this comment

jzelinskie Sep 7, 2016 • edited Loading

Choose a reason for hiding this comment

jzelinskie commented Sep 7, 2016

jordimassaguerpla commented Sep 22, 2016 • edited Loading

jzelinskie commented Sep 22, 2016

tboerger commented Sep 22, 2016

jordimassaguerpla commented Sep 23, 2016

arjunm183 commented Jul 12, 2017

jzelinskie commented Jul 13, 2017

flavio commented Sep 15, 2017

jzelinskie commented Sep 15, 2017

msmeissn commented Sep 17, 2017

Rots commented Nov 1, 2017

flavio commented Nov 2, 2017

LJosef commented Nov 20, 2017

chennanfei commented Nov 28, 2017

Payback159 commented Nov 29, 2017

maorgo commented Mar 5, 2018

flavio commented Mar 5, 2018

tboerger commented Jun 9, 2016 •

edited

Loading

Quentin-M commented Jun 9, 2016 •

edited

Loading

guypod commented Jul 13, 2016 •

edited

Loading

jzelinskie Sep 7, 2016 •

edited

Loading

jordimassaguerpla commented Sep 22, 2016 •

edited

Loading