Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing to detect CentOS 5 packages #215

Closed
ScalockScanner opened this issue Jul 14, 2016 · 6 comments
Closed

Failing to detect CentOS 5 packages #215

ScalockScanner opened this issue Jul 14, 2016 · 6 comments
Labels
kind/bug things are not as they seem

Comments

@ScalockScanner
Copy link

Clair wont find any vulnerabilities in Cenots 5.
This version is part of the supported systems

@Quentin-M
Copy link
Contributor

Hi,

Have you waited for the initial update to occur? You can try to debug what Clair knows about your image/layers using the API. There are few other related issues out there, you can probably dig in and see examples on how to figure out what's going on.

@Quentin-M Quentin-M added the kind/question something that couldn't be answered in the docs label Jul 14, 2016
@ScalockScanner
Copy link
Author

Hi Quentin,
I know about the update time issue, and its not that. I tested many images
centos 6 and centos 7 on several deployments configurations.
Centos 5 returns always clean

just to make sure I checked in my DB that the update process had ended when
the vulnerability table stops going up ~90,000 vulns..

So all the the DB is defiantly updated.

Were there any positive tests with Centos 5?

Thanks

On Thu, Jul 14, 2016 at 5:31 PM, Quentin Machu notifications@github.com
wrote:

Hi,

Have you waited for the initial update to occur? You can try to debug what
Clair knows about your image/layers using the API. There are few other
related issues out there, you can probably dig in and see examples on how
to figure out what's going on.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#215 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/APdTE4yo8bZMZQKy2c6pAUwoy6YtXwL2ks5qVkhWgaJpZM4JMZmr
.

@jzelinskie jzelinskie changed the title Clair support for Cenots 5 Failing to detect CentOS 5 packages Jul 14, 2016
@Quentin-M
Copy link
Contributor

Quentin-M commented Jul 15, 2016

Hi,

Here is why CentOS 5 returns clean as you pointed it out:

The RHEL updater currently ignores vulnerabilities for CentOS <= 5. As the naming of the constant firstConsideredRHEL suggests it, it should actually considers CentOS 5 and ignores CentOS < 5.

Thanks for the report!

@Quentin-M Quentin-M added component/updater kind/bug things are not as they seem and removed kind/question something that couldn't be answered in the docs labels Jul 15, 2016
Quentin-M added a commit to Quentin-M/clair that referenced this issue Jul 15, 2016
The RHEL updater currently ignores vulnerabilities for CentOS <= 5.
s the naming of the constant firstConsideredRHEL suggests it, it
should actually considers CentOS 5 and ignores CentOS < 5.

Fixes quay#215
jzelinskie pushed a commit that referenced this issue Jul 15, 2016
The RHEL updater currently ignores vulnerabilities for CentOS <= 5.
s the naming of the constant firstConsideredRHEL suggests it, it
should actually considers CentOS 5 and ignores CentOS < 5.

Fixes #215
Quentin-M added a commit that referenced this issue Jul 15, 2016
The RHEL updater currently ignores vulnerabilities for CentOS <= 5.
s the naming of the constant firstConsideredRHEL suggests it, it
should actually considers CentOS 5 and ignores CentOS < 5.

Fixes #215
Quentin-M added a commit that referenced this issue Jul 15, 2016
The RHEL updater currently ignores vulnerabilities for CentOS <= 5.
s the naming of the constant firstConsideredRHEL suggests it, it
should actually considers CentOS 5 and ignores CentOS < 5.

Fixes #215
@Quentin-M
Copy link
Contributor

Quentin-M commented Jul 18, 2016

@ScalockScanner Clair v1.2.3 contains the fix to your issue.

@ScalockScanner
Copy link
Author

Hi,
Thanks I saw the fix. Sorry for the late response. looks good.

Eli

On Tue, Jul 19, 2016 at 1:11 AM, Quentin Machu notifications@github.com
wrote:

@ScalockScanner https://github.com/ScalockScanner Clair v1.2.3 contain
the fix to your issue.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#215 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/APdTEw-VJlmT9xFBHtIuvS7WwDO6n41Yks5qW_osgaJpZM4JMZmr
.

@ScalockScanner
Copy link
Author

Hi Quentin,
Having some more issues with centos 5 scanning after the fix. getting an
error when updating the db with cves, ERROR:

2016-08-02 13:13:51.875583 E | pgsql: insertVulnerabilityFixedInFeature:
pq: duplicate key value violates unique constraint
"vulnerability_fixedin_feature_vulnerability_id_feature_id_key"
database.Vulnerability{Model:database.Model{ID:0}, Name:"RHSA-2009:0382",
Namespace:database.Namespace{Model:database.Model{ID:0}, Name:"centos:5"},
Description:"libvirt is a C API for managing and interacting with the
virtualization capabilities of Linux and other operating systems. libvirt
also provides tools for remotely managing virtualized systems. The libvirtd
daemon was discovered to not properly check user connection permissions
before performing certain privileged actions, such as requesting migration
of an unprivileged guest domain to another system. A local user able to
establish a read-only connection to libvirtd could use this flaw to perform
actions that should be restricted to read-write connections.
(CVE-2008-5086) libvirt_proxy, a setuid helper application allowing
non-privileged users to communicate with the hypervisor, was discovered to
not properly validate user requests. Local users could use this flaw to
cause a stack-based buffer overflow in libvirt_proxy, possibly allowing
them to run arbitrary code with root privileges. (CVE-2009-0036) All users
are advised to upgrade to these updated packages, which contain backported
patches which resolve these issues. After installing the update, libvirtd
must be restarted manually (for example, by issuing a "service libvirtd
restart" command), and guest systems rebooted, for this change to take
effect.", Link:"https://rhn.redhat.com/errata/RHSA-2009-0382.html",
Severity:"Medium", Metadata:database.MetadataMap(nil),
FixedIn:[]database.FeatureVersion{database.FeatureVersion{Model:database.Model{ID:0},
Feature:database.Feature{Model:database.Model{ID:0}, Name:"libvirt-devel",
Namespace:database.Namespace{Model:database.Model{ID:0}, Name:"centos:5"}},
Version:types.Version{epoch:0, version:"0.3.3", revision:"14.el5_3.1"},
AffectedBy:[]database.Vulnerability(nil),
AddedBy:database.Layer{Model:database.Model{ID:0}, Name:"",
EngineVersion:0, Parent:(_database.Layer)(nil),
Namespace:(_database.Namespace)(nil),
Features:[]database.FeatureVersion(nil)}},
database.FeatureVersion{Model:database.Model{ID:0},
Feature:database.Feature{Model:database.Model{ID:0}, Name:"libvirt",
Namespace:database.Namespace{Model:database.Model{ID:0}, Name:"centos:5"}},
Version:types.Version{epoch:0, version:"0.3.3", revision:"14.el5_3.1"},
AffectedBy:[]database.Vulnerability(nil),
AddedBy:database.Layer{Model:database.Model{ID:0}, Name:"",
EngineVersion:0, Parent:(_database.Layer)(nil),
Namespace:(_database.Namespace)(nil),
Features:[]database.FeatureVersion(nil)}},
database.FeatureVersion{Model:database.Model{ID:0},
Feature:database.Feature{Model:database.Model{ID:0}, Name:"libvirt-python",
Namespace:database.Namespace{Model:database.Model{ID:0}, Name:"centos:5"}},
Version:types.Version{epoch:0, version:"0.3.3", revision:"14.el5_3.1"},
AffectedBy:[]database.Vulnerability(nil),
AddedBy:database.Layer{Model:database.Model{ID:0}, Name:"",
EngineVersion:0, Parent:(_database.Layer)(nil),
Namespace:(_database.Namespace)(nil),
Features:[]database.FeatureVersion(nil)}},
database.FeatureVersion{Model:database.Model{ID:0},
Feature:database.Feature{Model:database.Model{ID:0}, Name:"libvirt-devel",
Namespace:database.Namespace{Model:database.Model{ID:0}, Name:"centos:5"}},
Version:types.Version{epoch:0, version:"0.3.3", revision:"14.el5_3.1"},
AffectedBy:[]database.Vulnerability(nil),
AddedBy:database.Layer{Model:database.Model{ID:0}, Name:"",
EngineVersion:0, Parent:(_database.Layer)(nil),
Namespace:(_database.Namespace)(nil),
Features:[]database.FeatureVersion(nil)}},
database.FeatureVersion{Model:database.Model{ID:0},
Feature:database.Feature{Model:database.Model{ID:0}, Name:"libvirt",
Namespace:database.Namespace{Model:database.Model{ID:0}, Name:"centos:5"}},
Version:types.Version{epoch:0, version:"0.3.3", revision:"14.el5_3.1"},
AffectedBy:[]database.Vulnerability(nil),
AddedBy:database.Layer{Model:database.Model{ID:0}, Name:"",
EngineVersion:0, Parent:(_database.Layer)(nil),
Namespace:(_database.Namespace)(nil),
Features:[]database.FeatureVersion(nil)}},
database.FeatureVersion{Model:database.Model{ID:0},
Feature:database.Feature{Model:database.Model{ID:0}, Name:"libvirt-python",
Namespace:database.Namespace{Model:database.Model{ID:0}, Name:"centos:5"}},
Version:types.Version{epoch:0, version:"0.3.3", revision:"14.el5_3.1"},
AffectedBy:[]database.Vulnerability(nil),
AddedBy:database.Layer{Model:database.Model{ID:0}, Name:"",
EngineVersion:0, Parent:(_database.Layer)(nil),
Namespace:(_database.Namespace)(nil),
Features:[]database.FeatureVersion(nil)}}},
LayersIntroducingVulnerability:[]database.Layer(nil),
FixedBy:types.Version{epoch:0, version:"", revision:""}}

it seems that a cve belongs to Centos 5 violates uniqueness of an existing
cve

On Tue, Jul 19, 2016 at 1:11 AM, Quentin Machu notifications@github.com
wrote:

@ScalockScanner https://github.com/ScalockScanner Clair v1.2.3 contain
the fix to your issue.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#215 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/APdTEw-VJlmT9xFBHtIuvS7WwDO6n41Yks5qW_osgaJpZM4JMZmr
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug things are not as they seem
Development

No branches or pull requests

2 participants