Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace liamstask/goose by remind101/migrate #261

Merged
merged 1 commit into from
Nov 11, 2016
Merged

Replace liamstask/goose by remind101/migrate #261

merged 1 commit into from
Nov 11, 2016

Conversation

Quentin-M
Copy link
Contributor

@Quentin-M Quentin-M commented Nov 11, 2016 •
edited

This PR replaces our current migrator tool for PostgreSQL (liamstack/goose), which is an abandoned project, by a simpler one.

  • Migrations can now be embedded,
  • An advisory lock is maintained on the database during the migration process,
  • The initial database migration is now the second migration, instead of the first one. The first one verifies if there's a goose's table present in the database, if that is the case,it is removed the initial database migration is marked as completed for the new migrator.

Fixes #93

+997 −2,224

What could go wrong?

@jzelinskie
Copy link
Contributor

What could go wrong?

The CI could fail XD

@Quentin-M
Copy link
Contributor Author

Quentin-M commented Nov 11, 2016 •
edited

Calculated!

@Quentin-M Quentin-M added area/distribution related to means of distributing the project area/usability related to improving user experience component/database labels Nov 11, 2016
jzelinskie
jzelinskie approved these changes Nov 11, 2016
View reviewed changes
Copy link
Contributor

@jzelinskie jzelinskie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay

@Quentin-M Quentin-M merged commit 43cbc04 into quay:master Nov 11, 2016
@Quentin-M Quentin-M deleted the replace_goose branch November 11, 2016 18:26
@Quentin-M Quentin-M mentioned this pull request Nov 16, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzelinskie jzelinskie jzelinskie approved these changes

Assignees

@jzelinskie jzelinskie

Labels
area/distribution related to means of distributing the project area/usability related to improving user experience
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Quentin-M @jzelinskie