Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve database migration strategy #93

Closed
Quentin-M opened this issue Mar 8, 2016 · 4 comments
Closed

Improve database migration strategy #93

Quentin-M opened this issue Mar 8, 2016 · 4 comments
Labels
area/distribution related to means of distributing the project area/usability related to improving user experience help wanted a good issue for non-maintainers to handle priority/medium desired functionality

Comments

@Quentin-M
Copy link
Contributor

Quentin-M commented Mar 8, 2016 •
edited

We currently use liamstask/goose, it allows doing both .go and .sql migrations. However, it requires a working Go environment and migration files aren't embed in the Clair binary, and thus, we can't distribute a single binary.
@jzelinskie
Copy link
Contributor

related project: https://github.com/jteeuwen/go-bindata

@fatalbanana fatalbanana mentioned this issue Mar 9, 2016
Closed
@jzelinskie jzelinskie added help wanted a good issue for non-maintainers to handle area/distribution related to means of distributing the project area/usability related to improving user experience priority/medium desired functionality component/database labels Mar 11, 2016
@Quentin-M Quentin-M added this to the 2.0 milestone Apr 19, 2016
@Quentin-M Quentin-M mentioned this issue Jun 3, 2016
Closed
@Quentin-M
Copy link
Contributor Author

^ As discussed before, go-bindata is not applicable. It wouldn't help running .go migrations without a go env.

@Quentin-M Quentin-M changed the title Embed SQL migrations Improve database migration strategy Jun 7, 2016
@Quentin-M Quentin-M mentioned this issue Jun 9, 2016
Closed
@ejholmes
Copy link

ejholmes commented Oct 4, 2016

@Quentin-M we extracted https://github.com/remind101/migrate from https://github.com/remind101/empire. Fairly simple, and designed for embedding.

@Quentin-M
Copy link
Contributor Author

@ejholmes That's awesome. Thank you for the tip!

Quentin-M added a commit to Quentin-M/clair that referenced this issue Nov 11, 2016
@Quentin-M
Replace liamstask/goose by remind101/migrate
6b165ac 
Fixes quay#93
@Quentin-M Quentin-M mentioned this issue Nov 11, 2016
Merged
Quentin-M added a commit to Quentin-M/clair that referenced this issue Nov 11, 2016
@Quentin-M
Replace liamstask/goose by remind101/migrate
af049df 
Fixes quay#93
Quentin-M added a commit to Quentin-M/clair that referenced this issue Nov 11, 2016
@Quentin-M
Replace liamstask/goose by remind101/migrate
db4db66 
Fixes quay#93
Quentin-M added a commit to Quentin-M/clair that referenced this issue Nov 11, 2016
@Quentin-M
pgsql: Replace liamstask/goose by remind101/migrate
b8865b2 
Fixes quay#93
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/distribution related to means of distributing the project area/usability related to improving user experience help wanted a good issue for non-maintainers to handle priority/medium desired functionality
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ejholmes @jzelinskie @Quentin-M