Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contrib/helm/clair not up to date with 2.0+ config.yaml #561

Closed
ArcticSnowman opened this issue Jun 14, 2018 · 1 comment
Closed

contrib/helm/clair not up to date with 2.0+ config.yaml #561

ArcticSnowman opened this issue Jun 14, 2018 · 1 comment
Labels
area/dev tooling related to tools used by developers kind/bug things are not as they seem low hanging fruit easy for new contributors

Comments

@ArcticSnowman
Copy link

ArcticSnowman commented Jun 14, 2018 •
edited

The way the PostgreSQL connection string is store in the config.yaml has changed with 2.0 release.

The template/configmap.yaml is still pre 2.0

source: "postgres://{{ .Values.postgresql.postgresUser }}:{{ .Values.postgresql.postgresPassword }}@{{ template "postgresql.fullname" . }}:5432/{{ .Values.postgresql.postgresDatabase }}?sslmode=disable"
@jzelinskie jzelinskie added area/dev tooling related to tools used by developers low hanging fruit easy for new contributors kind/bug things are not as they seem labels Jul 6, 2018
naibaf0 pushed a commit to naibaf0/clair that referenced this issue Jul 19, 2018
Helm: change postgresql connection string format in configmap template
cf5eabd 
The PostgreSQL connection string in the configmap template for helm was
changed to a key-value format to reflect the currently used format in
the sample config file

Fixes quay#561
@naibaf0 naibaf0 mentioned this issue Jul 19, 2018
Merged
@jzelinskie
Copy link
Contributor

Either of these formats should work. The documentation just specifies the key value pair because it's easier to read/write and we had users making mistakes with the URI format.

naibaf0 pushed a commit to naibaf0/clair that referenced this issue Aug 13, 2018
Helm: change postgresql connection string format in configmap template
690d26e 
The PostgreSQL connection string in the configmap template for helm was
changed to a key-value format to reflect the currently used format in
the sample config file

Fixes quay#561
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/dev tooling related to tools used by developers kind/bug things are not as they seem low hanging fruit easy for new contributors
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jzelinskie @ArcticSnowman