Helm: change postgresql connection string format in configmap template #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Either of these formats should work. If you rebase and get things working on the latest Helm chart, I'll update this to at least make things more aligned with the documentation, though. |
The PostgreSQL connection string in the configmap template for helm was changed to a key-value format to reflect the currently used format in the sample config file Fixes quay#561
naibaf0
force-pushed
the
fix/helmtemplate/configmap/postgresql
branch
from
cf5eabd
to
690d26e
Compare
jzelinskie
approved these changes
Aug 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PostgreSQL connection string in the configmap template for helm was
changed to a key-value format to reflect the currently used format in
the sample config file
Fixes #561